mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 13:53:33 +00:00
signals: kill the obsolete sigdelset() and recalc_sigpending() in allow_signal()
allow_signal() does sigdelset(current->blocked) due to historic reason, previously it could be called by a daemonize()'ed kthread, and daemonize() played with current->blocked. Now that daemonize() has gone away we can remove sigdelset() and recalc_sigpending(). If a user really wants to unblock a signal, it must use sigprocmask() or set_current_block() explicitely. Signed-off-by: Oleg Nesterov <oleg@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Al Viro <viro@ZenIV.linux.org.uk> Cc: David Woodhouse <dwmw2@infradead.org> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Ingo Molnar <mingo@kernel.org> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Richard Weinberger <richard@nod.at> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Tejun Heo <tj@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
c240837fa7
commit
ec5955b8fd
1 changed files with 1 additions and 4 deletions
|
@ -3072,16 +3072,13 @@ COMPAT_SYSCALL_DEFINE4(rt_tgsigqueueinfo,
|
||||||
*/
|
*/
|
||||||
void allow_signal(int sig)
|
void allow_signal(int sig)
|
||||||
{
|
{
|
||||||
spin_lock_irq(¤t->sighand->siglock);
|
|
||||||
/* This is only needed for daemonize()'ed kthreads */
|
|
||||||
sigdelset(¤t->blocked, sig);
|
|
||||||
/*
|
/*
|
||||||
* Kernel threads handle their own signals. Let the signal code
|
* Kernel threads handle their own signals. Let the signal code
|
||||||
* know it'll be handled, so that they don't get converted to
|
* know it'll be handled, so that they don't get converted to
|
||||||
* SIGKILL or just silently dropped.
|
* SIGKILL or just silently dropped.
|
||||||
*/
|
*/
|
||||||
|
spin_lock_irq(¤t->sighand->siglock);
|
||||||
current->sighand->action[(sig)-1].sa.sa_handler = (void __user *)2;
|
current->sighand->action[(sig)-1].sa.sa_handler = (void __user *)2;
|
||||||
recalc_sigpending();
|
|
||||||
spin_unlock_irq(¤t->sighand->siglock);
|
spin_unlock_irq(¤t->sighand->siglock);
|
||||||
}
|
}
|
||||||
EXPORT_SYMBOL(allow_signal);
|
EXPORT_SYMBOL(allow_signal);
|
||||||
|
|
Loading…
Reference in a new issue