mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 13:55:32 +00:00
[NETFILTER]: ipt_TCPMSS: misc cleanup
- remove debugging cruft - remove printk for reallocation failures - remove unused addition Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
2be344c446
commit
ecb70c95c4
1 changed files with 2 additions and 34 deletions
|
@ -21,12 +21,6 @@ MODULE_LICENSE("GPL");
|
||||||
MODULE_AUTHOR("Marc Boucher <marc@mbsi.ca>");
|
MODULE_AUTHOR("Marc Boucher <marc@mbsi.ca>");
|
||||||
MODULE_DESCRIPTION("iptables TCP MSS modification module");
|
MODULE_DESCRIPTION("iptables TCP MSS modification module");
|
||||||
|
|
||||||
#if 0
|
|
||||||
#define DEBUGP printk
|
|
||||||
#else
|
|
||||||
#define DEBUGP(format, args...)
|
|
||||||
#endif
|
|
||||||
|
|
||||||
static inline unsigned int
|
static inline unsigned int
|
||||||
optlen(const u_int8_t *opt, unsigned int offset)
|
optlen(const u_int8_t *opt, unsigned int offset)
|
||||||
{
|
{
|
||||||
|
@ -106,16 +100,7 @@ ipt_tcpmss_target(struct sk_buff **pskb,
|
||||||
htons(oldmss)^0xFFFF,
|
htons(oldmss)^0xFFFF,
|
||||||
htons(newmss),
|
htons(newmss),
|
||||||
tcph->check, 0);
|
tcph->check, 0);
|
||||||
|
return IPT_CONTINUE;
|
||||||
DEBUGP(KERN_INFO "ipt_tcpmss_target: %u.%u.%u.%u:%hu"
|
|
||||||
"->%u.%u.%u.%u:%hu changed TCP MSS option"
|
|
||||||
" (from %u to %u)\n",
|
|
||||||
NIPQUAD((*pskb)->nh.iph->saddr),
|
|
||||||
ntohs(tcph->source),
|
|
||||||
NIPQUAD((*pskb)->nh.iph->daddr),
|
|
||||||
ntohs(tcph->dest),
|
|
||||||
oldmss, newmss);
|
|
||||||
goto retmodified;
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -127,13 +112,8 @@ ipt_tcpmss_target(struct sk_buff **pskb,
|
||||||
|
|
||||||
newskb = skb_copy_expand(*pskb, skb_headroom(*pskb),
|
newskb = skb_copy_expand(*pskb, skb_headroom(*pskb),
|
||||||
TCPOLEN_MSS, GFP_ATOMIC);
|
TCPOLEN_MSS, GFP_ATOMIC);
|
||||||
if (!newskb) {
|
if (!newskb)
|
||||||
if (net_ratelimit())
|
|
||||||
printk(KERN_ERR "ipt_tcpmss_target:"
|
|
||||||
" unable to allocate larger skb\n");
|
|
||||||
return NF_DROP;
|
return NF_DROP;
|
||||||
}
|
|
||||||
|
|
||||||
kfree_skb(*pskb);
|
kfree_skb(*pskb);
|
||||||
*pskb = newskb;
|
*pskb = newskb;
|
||||||
iph = (*pskb)->nh.iph;
|
iph = (*pskb)->nh.iph;
|
||||||
|
@ -149,8 +129,6 @@ ipt_tcpmss_target(struct sk_buff **pskb,
|
||||||
htons(tcplen) ^ 0xFFFF,
|
htons(tcplen) ^ 0xFFFF,
|
||||||
htons(tcplen + TCPOLEN_MSS),
|
htons(tcplen + TCPOLEN_MSS),
|
||||||
tcph->check, 1);
|
tcph->check, 1);
|
||||||
tcplen += TCPOLEN_MSS;
|
|
||||||
|
|
||||||
opt[0] = TCPOPT_MSS;
|
opt[0] = TCPOPT_MSS;
|
||||||
opt[1] = TCPOLEN_MSS;
|
opt[1] = TCPOLEN_MSS;
|
||||||
opt[2] = (newmss & 0xff00) >> 8;
|
opt[2] = (newmss & 0xff00) >> 8;
|
||||||
|
@ -170,16 +148,6 @@ ipt_tcpmss_target(struct sk_buff **pskb,
|
||||||
iph->check = nf_csum_update(iph->tot_len ^ 0xFFFF,
|
iph->check = nf_csum_update(iph->tot_len ^ 0xFFFF,
|
||||||
newtotlen, iph->check);
|
newtotlen, iph->check);
|
||||||
iph->tot_len = newtotlen;
|
iph->tot_len = newtotlen;
|
||||||
|
|
||||||
DEBUGP(KERN_INFO "ipt_tcpmss_target: %u.%u.%u.%u:%hu"
|
|
||||||
"->%u.%u.%u.%u:%hu added TCP MSS option (%u)\n",
|
|
||||||
NIPQUAD((*pskb)->nh.iph->saddr),
|
|
||||||
ntohs(tcph->source),
|
|
||||||
NIPQUAD((*pskb)->nh.iph->daddr),
|
|
||||||
ntohs(tcph->dest),
|
|
||||||
newmss);
|
|
||||||
|
|
||||||
retmodified:
|
|
||||||
return IPT_CONTINUE;
|
return IPT_CONTINUE;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue