[MTD] cmdlinepart.c: don't compare pointers with 0

Sparse spotted that 0 was compared to pointers.

While I was at it, I also moved the assignments out of the if's.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
This commit is contained in:
Adrian Bunk 2008-04-14 17:20:04 +03:00 committed by David Woodhouse
parent 456d9fc92e
commit ed262c4f5c

View file

@ -119,7 +119,8 @@ static struct mtd_partition * newpart(char *s,
char *p; char *p;
name = ++s; name = ++s;
if ((p = strchr(name, delim)) == 0) p = strchr(name, delim);
if (!p)
{ {
printk(KERN_ERR ERRP "no closing %c found in partition name\n", delim); printk(KERN_ERR ERRP "no closing %c found in partition name\n", delim);
return NULL; return NULL;
@ -159,9 +160,10 @@ static struct mtd_partition * newpart(char *s,
return NULL; return NULL;
} }
/* more partitions follow, parse them */ /* more partitions follow, parse them */
if ((parts = newpart(s + 1, &s, num_parts, parts = newpart(s + 1, &s, num_parts, this_part + 1,
this_part + 1, &extra_mem, extra_mem_size)) == 0) &extra_mem, extra_mem_size);
return NULL; if (!parts)
return NULL;
} }
else else
{ /* this is the last partition: allocate space for all */ { /* this is the last partition: allocate space for all */