mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-06 08:46:46 +00:00
[PATCH] Remove superfluous lock_super() in extN xattr code
lock_super() is unnecessary for setting super-block feature flags. Use the provided *_SET_COMPAT_FEATURE() macros as well. Signed-off-by: Andreas Gruenbacher <agruen@suse.de> Cc: <linux-ext4@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
696040670a
commit
ed2908f313
3 changed files with 3 additions and 12 deletions
|
@ -342,12 +342,9 @@ static void ext2_xattr_update_super_block(struct super_block *sb)
|
||||||
if (EXT2_HAS_COMPAT_FEATURE(sb, EXT2_FEATURE_COMPAT_EXT_ATTR))
|
if (EXT2_HAS_COMPAT_FEATURE(sb, EXT2_FEATURE_COMPAT_EXT_ATTR))
|
||||||
return;
|
return;
|
||||||
|
|
||||||
lock_super(sb);
|
EXT2_SET_COMPAT_FEATURE(sb, EXT2_FEATURE_COMPAT_EXT_ATTR);
|
||||||
EXT2_SB(sb)->s_es->s_feature_compat |=
|
|
||||||
cpu_to_le32(EXT2_FEATURE_COMPAT_EXT_ATTR);
|
|
||||||
sb->s_dirt = 1;
|
sb->s_dirt = 1;
|
||||||
mark_buffer_dirty(EXT2_SB(sb)->s_sbh);
|
mark_buffer_dirty(EXT2_SB(sb)->s_sbh);
|
||||||
unlock_super(sb);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
|
|
@ -459,14 +459,11 @@ static void ext3_xattr_update_super_block(handle_t *handle,
|
||||||
if (EXT3_HAS_COMPAT_FEATURE(sb, EXT3_FEATURE_COMPAT_EXT_ATTR))
|
if (EXT3_HAS_COMPAT_FEATURE(sb, EXT3_FEATURE_COMPAT_EXT_ATTR))
|
||||||
return;
|
return;
|
||||||
|
|
||||||
lock_super(sb);
|
|
||||||
if (ext3_journal_get_write_access(handle, EXT3_SB(sb)->s_sbh) == 0) {
|
if (ext3_journal_get_write_access(handle, EXT3_SB(sb)->s_sbh) == 0) {
|
||||||
EXT3_SB(sb)->s_es->s_feature_compat |=
|
EXT3_SET_COMPAT_FEATURE(sb, EXT3_FEATURE_COMPAT_EXT_ATTR);
|
||||||
cpu_to_le32(EXT3_FEATURE_COMPAT_EXT_ATTR);
|
|
||||||
sb->s_dirt = 1;
|
sb->s_dirt = 1;
|
||||||
ext3_journal_dirty_metadata(handle, EXT3_SB(sb)->s_sbh);
|
ext3_journal_dirty_metadata(handle, EXT3_SB(sb)->s_sbh);
|
||||||
}
|
}
|
||||||
unlock_super(sb);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
|
|
@ -459,14 +459,11 @@ static void ext4_xattr_update_super_block(handle_t *handle,
|
||||||
if (EXT4_HAS_COMPAT_FEATURE(sb, EXT4_FEATURE_COMPAT_EXT_ATTR))
|
if (EXT4_HAS_COMPAT_FEATURE(sb, EXT4_FEATURE_COMPAT_EXT_ATTR))
|
||||||
return;
|
return;
|
||||||
|
|
||||||
lock_super(sb);
|
|
||||||
if (ext4_journal_get_write_access(handle, EXT4_SB(sb)->s_sbh) == 0) {
|
if (ext4_journal_get_write_access(handle, EXT4_SB(sb)->s_sbh) == 0) {
|
||||||
EXT4_SB(sb)->s_es->s_feature_compat |=
|
EXT4_SET_COMPAT_FEATURE(sb, EXT4_FEATURE_COMPAT_EXT_ATTR);
|
||||||
cpu_to_le32(EXT4_FEATURE_COMPAT_EXT_ATTR);
|
|
||||||
sb->s_dirt = 1;
|
sb->s_dirt = 1;
|
||||||
ext4_journal_dirty_metadata(handle, EXT4_SB(sb)->s_sbh);
|
ext4_journal_dirty_metadata(handle, EXT4_SB(sb)->s_sbh);
|
||||||
}
|
}
|
||||||
unlock_super(sb);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
|
Loading…
Reference in a new issue