mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-05 16:37:50 +00:00
dmaengine: qcom: bam_dma: use struct_size() in kzalloc()
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); Instead of leaving these open-coded and prone to type mistakes, we can now use the new struct_size() helper: instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL); This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
parent
a474b3f042
commit
edd3c38999
1 changed files with 2 additions and 2 deletions
|
@ -636,8 +636,8 @@ static struct dma_async_tx_descriptor *bam_prep_slave_sg(struct dma_chan *chan,
|
||||||
num_alloc += DIV_ROUND_UP(sg_dma_len(sg), BAM_FIFO_SIZE);
|
num_alloc += DIV_ROUND_UP(sg_dma_len(sg), BAM_FIFO_SIZE);
|
||||||
|
|
||||||
/* allocate enough room to accomodate the number of entries */
|
/* allocate enough room to accomodate the number of entries */
|
||||||
async_desc = kzalloc(sizeof(*async_desc) +
|
async_desc = kzalloc(struct_size(async_desc, desc, num_alloc),
|
||||||
(num_alloc * sizeof(struct bam_desc_hw)), GFP_NOWAIT);
|
GFP_NOWAIT);
|
||||||
|
|
||||||
if (!async_desc)
|
if (!async_desc)
|
||||||
goto err_out;
|
goto err_out;
|
||||||
|
|
Loading…
Reference in a new issue