mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-19 17:11:03 +00:00
net: appletalk: cops: Fix data race in cops_probe1
[ Upstream commit a4dd4fc610
]
In cops_probe1(), there is a write to dev->base_addr after requesting an
interrupt line and registering the interrupt handler cops_interrupt().
The handler might be called in parallel to handle an interrupt.
cops_interrupt() tries to read dev->base_addr leading to a potential
data race. So write to dev->base_addr before calling request_irq().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Saubhik Mukherjee <saubhik.mukherjee@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
a385cbf31e
commit
ee144b7980
1 changed files with 2 additions and 2 deletions
|
@ -327,6 +327,8 @@ static int __init cops_probe1(struct net_device *dev, int ioaddr)
|
|||
break;
|
||||
}
|
||||
|
||||
dev->base_addr = ioaddr;
|
||||
|
||||
/* Reserve any actual interrupt. */
|
||||
if (dev->irq) {
|
||||
retval = request_irq(dev->irq, cops_interrupt, 0, dev->name, dev);
|
||||
|
@ -334,8 +336,6 @@ static int __init cops_probe1(struct net_device *dev, int ioaddr)
|
|||
goto err_out;
|
||||
}
|
||||
|
||||
dev->base_addr = ioaddr;
|
||||
|
||||
lp = netdev_priv(dev);
|
||||
spin_lock_init(&lp->lock);
|
||||
|
||||
|
|
Loading…
Reference in a new issue