mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 02:39:48 +00:00
staging: r8712u: Fix Smatch warning
The patch 2080913e01
: "staging: r8712u: Fix regression caused by
commit 8c213fa" from Feb 25, 2012, leads to the following Smatch
complaint:
drivers/staging/rtl8712/usb_intf.c:629 r871xu_dev_remove()
warn: variable dereferenced before check 'padapter' (see line 625)
The fix is to move the new statements inside the block where padapter
is not NULL.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
b76dee4a41
commit
ee6aeff71e
1 changed files with 4 additions and 4 deletions
|
@ -620,12 +620,12 @@ static void r871xu_dev_remove(struct usb_interface *pusb_intf)
|
|||
struct _adapter *padapter = netdev_priv(pnetdev);
|
||||
struct usb_device *udev = interface_to_usbdev(pusb_intf);
|
||||
|
||||
if (padapter->fw_found)
|
||||
release_firmware(padapter->fw);
|
||||
/* never exit with a firmware callback pending */
|
||||
wait_for_completion(&padapter->rtl8712_fw_ready);
|
||||
usb_set_intfdata(pusb_intf, NULL);
|
||||
if (padapter) {
|
||||
if (padapter->fw_found)
|
||||
release_firmware(padapter->fw);
|
||||
/* never exit with a firmware callback pending */
|
||||
wait_for_completion(&padapter->rtl8712_fw_ready);
|
||||
if (drvpriv.drv_registered == true)
|
||||
padapter->bSurpriseRemoved = true;
|
||||
if (pnetdev != NULL) {
|
||||
|
|
Loading…
Reference in a new issue