mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-12 05:48:40 +00:00
Code Issues Releases Wiki Activity

greybus: operation: use dev_err in gb_operation_sync

Browse source 
Use the more informative dev_err in gb_operation_sync, which includes
the connection device name in the error message (which in turn encodes
the module, interface, bundle and cport ids).

Add missing braces to conditional-construct branches while at it.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
Johan Hovold 2015-03-19 16:46:18 +01:00 committed by Greg Kroah-Hartman
parent 25eb732954
commit ee8f81b096
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/staging/greybus/operation.c
View file

@ -945,12 +945,15 @@ int gb_operation_sync(struct gb_connection *connection, int type,
memcpy(operation->request->payload, request, request_size);
ret = gb_operation_request_send_sync(operation);
if (ret)
pr_err("synchronous operation failed (%d)\n", ret);
else
if (response_size)
if (ret) {
dev_err(&connection->dev, "synchronous operation failed: %d\n",
ret);
} else {
if (response_size) {
memcpy(response, operation->response->payload,
response_size);
}
}
gb_operation_destroy(operation);
return ret;