mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 23:27:06 +00:00
ALSA: pci: lx6464es: fix a debug loop
[ Upstream commit5dac9f8dc2
] This loop accidentally reuses the "i" iterator for both the inside and the outside loop. The value of MAX_STREAM_BUFFER is 5. I believe that chip->rmh.stat_len is in the 2-12 range. If the value of .stat_len is 4 or more then it will loop exactly one time, but if it's less then it is a forever loop. It looks like it was supposed to combined into one loop where conditions are checked. Fixes:8e6320064c
("ALSA: lx_core: Remove useless #if 0 .. #endif") Signed-off-by: Dan Carpenter <error27@gmail.com> Link: https://lore.kernel.org/r/Y9jnJTis/mRFJAQp@kili Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
3914b71dad
commit
ef3edede7b
1 changed files with 5 additions and 6 deletions
|
@ -493,12 +493,11 @@ int lx_buffer_ask(struct lx6464es *chip, u32 pipe, int is_capture,
|
||||||
dev_dbg(chip->card->dev,
|
dev_dbg(chip->card->dev,
|
||||||
"CMD_08_ASK_BUFFERS: needed %d, freed %d\n",
|
"CMD_08_ASK_BUFFERS: needed %d, freed %d\n",
|
||||||
*r_needed, *r_freed);
|
*r_needed, *r_freed);
|
||||||
for (i = 0; i < MAX_STREAM_BUFFER; ++i) {
|
for (i = 0; i < MAX_STREAM_BUFFER && i < chip->rmh.stat_len;
|
||||||
for (i = 0; i != chip->rmh.stat_len; ++i)
|
++i) {
|
||||||
dev_dbg(chip->card->dev,
|
dev_dbg(chip->card->dev, " stat[%d]: %x, %x\n", i,
|
||||||
" stat[%d]: %x, %x\n", i,
|
chip->rmh.stat[i],
|
||||||
chip->rmh.stat[i],
|
chip->rmh.stat[i] & MASK_DATA_SIZE);
|
||||||
chip->rmh.stat[i] & MASK_DATA_SIZE);
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue