mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 02:19:51 +00:00
drm/fsl-dcu: specify volatile registers
Since we are using cached registers, we need to specify volatile registers explicitly to avoid reading their value from the cache. This allows to read the correct interrupt status in fsl_dcu_drm_irq and clear the asserted bits only. Signed-off-by: Stefan Agner <stefan@agner.ch>
This commit is contained in:
parent
a36c9867d4
commit
efb8b49196
1 changed files with 11 additions and 1 deletions
|
@ -28,11 +28,21 @@
|
|||
#include "fsl_dcu_drm_crtc.h"
|
||||
#include "fsl_dcu_drm_drv.h"
|
||||
|
||||
static bool fsl_dcu_drm_is_volatile_reg(struct device *dev, unsigned int reg)
|
||||
{
|
||||
if (reg == DCU_INT_STATUS || reg == DCU_UPDATE_MODE)
|
||||
return true;
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
static const struct regmap_config fsl_dcu_regmap_config = {
|
||||
.reg_bits = 32,
|
||||
.reg_stride = 4,
|
||||
.val_bits = 32,
|
||||
.cache_type = REGCACHE_RBTREE,
|
||||
|
||||
.volatile_reg = fsl_dcu_drm_is_volatile_reg,
|
||||
};
|
||||
|
||||
static int fsl_dcu_drm_irq_init(struct drm_device *dev)
|
||||
|
@ -125,7 +135,7 @@ static irqreturn_t fsl_dcu_drm_irq(int irq, void *arg)
|
|||
if (int_status & DCU_INT_STATUS_VBLANK)
|
||||
drm_handle_vblank(dev, 0);
|
||||
|
||||
ret = regmap_write(fsl_dev->regmap, DCU_INT_STATUS, 0xffffffff);
|
||||
ret = regmap_write(fsl_dev->regmap, DCU_INT_STATUS, int_status);
|
||||
if (ret)
|
||||
dev_err(dev->dev, "set DCU_INT_STATUS failed\n");
|
||||
ret = regmap_write(fsl_dev->regmap, DCU_UPDATE_MODE,
|
||||
|
|
Loading…
Reference in a new issue