mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 21:03:32 +00:00
usb: gadget: tegra-xudc: Fix error check in tegra_xudc_powerdomain_init()
dev_pm_domain_attach_by_name() may return NULL in some cases,
so IS_ERR() doesn't meet the requirements. Thus fix it.
Fixes: 49db427232
("usb: gadget: Add UDC driver for tegra XUSB device mode controller")
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Link: https://lore.kernel.org/r/20220525135332.23144-1-tangbin@cmss.chinamobile.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
7afe69ad92
commit
f08aa7c80d
1 changed files with 4 additions and 4 deletions
|
@ -3691,15 +3691,15 @@ static int tegra_xudc_powerdomain_init(struct tegra_xudc *xudc)
|
||||||
int err;
|
int err;
|
||||||
|
|
||||||
xudc->genpd_dev_device = dev_pm_domain_attach_by_name(dev, "dev");
|
xudc->genpd_dev_device = dev_pm_domain_attach_by_name(dev, "dev");
|
||||||
if (IS_ERR(xudc->genpd_dev_device)) {
|
if (IS_ERR_OR_NULL(xudc->genpd_dev_device)) {
|
||||||
err = PTR_ERR(xudc->genpd_dev_device);
|
err = PTR_ERR(xudc->genpd_dev_device) ? : -ENODATA;
|
||||||
dev_err(dev, "failed to get device power domain: %d\n", err);
|
dev_err(dev, "failed to get device power domain: %d\n", err);
|
||||||
return err;
|
return err;
|
||||||
}
|
}
|
||||||
|
|
||||||
xudc->genpd_dev_ss = dev_pm_domain_attach_by_name(dev, "ss");
|
xudc->genpd_dev_ss = dev_pm_domain_attach_by_name(dev, "ss");
|
||||||
if (IS_ERR(xudc->genpd_dev_ss)) {
|
if (IS_ERR_OR_NULL(xudc->genpd_dev_ss)) {
|
||||||
err = PTR_ERR(xudc->genpd_dev_ss);
|
err = PTR_ERR(xudc->genpd_dev_ss) ? : -ENODATA;
|
||||||
dev_err(dev, "failed to get SuperSpeed power domain: %d\n", err);
|
dev_err(dev, "failed to get SuperSpeed power domain: %d\n", err);
|
||||||
return err;
|
return err;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue