mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-15 23:25:07 +00:00
mm/memory_hotplug: rate limit page migration warnings
commit 786dee8648
upstream.
When offlining memory the system can attempt to migrate a lot of pages, if
there are problems with migration this can flood the logs. Printing all
the data hogs the CPU and cause some RT threads to run for a long time,
which may have some bad consequences.
Rate limit the page migration warnings in order to avoid this.
Link: https://lkml.kernel.org/r/20210505140542.24935-1-georgi.djakov@linaro.org
Signed-off-by: Liam Mark <lmark@codeaurora.org>
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
Cc: David Hildenbrand <david@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: <pjy@amazon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
bf97ea76ea
commit
f10690787d
1 changed files with 11 additions and 5 deletions
|
@ -1279,6 +1279,8 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
|
|||
struct page *page, *head;
|
||||
int ret = 0;
|
||||
LIST_HEAD(source);
|
||||
static DEFINE_RATELIMIT_STATE(migrate_rs, DEFAULT_RATELIMIT_INTERVAL,
|
||||
DEFAULT_RATELIMIT_BURST);
|
||||
|
||||
for (pfn = start_pfn; pfn < end_pfn; pfn++) {
|
||||
if (!pfn_valid(pfn))
|
||||
|
@ -1325,9 +1327,11 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
|
|||
page_is_file_lru(page));
|
||||
|
||||
} else {
|
||||
if (__ratelimit(&migrate_rs)) {
|
||||
pr_warn("failed to isolate pfn %lx\n", pfn);
|
||||
dump_page(page, "isolation failed");
|
||||
}
|
||||
}
|
||||
put_page(page);
|
||||
}
|
||||
if (!list_empty(&source)) {
|
||||
|
@ -1355,10 +1359,12 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
|
|||
(unsigned long)&mtc, MIGRATE_SYNC, MR_MEMORY_HOTPLUG);
|
||||
if (ret) {
|
||||
list_for_each_entry(page, &source, lru) {
|
||||
pr_warn("migrating pfn %lx failed ret:%d ",
|
||||
if (__ratelimit(&migrate_rs)) {
|
||||
pr_warn("migrating pfn %lx failed ret:%d\n",
|
||||
page_to_pfn(page), ret);
|
||||
dump_page(page, "migration failure");
|
||||
}
|
||||
}
|
||||
putback_movable_pages(&source);
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue