parisc: pdc_stable: Fix kdoc and compiler warnings

Signed-off-by: Helge Deller <deller@gmx.de>
This commit is contained in:
Helge Deller 2023-06-30 12:33:09 +02:00
parent 658e105712
commit f28a98779d

View file

@ -509,6 +509,8 @@ static struct pdcspath_entry *pdcspath_entries[] = {
/** /**
* pdcs_size_read - Stable Storage size output. * pdcs_size_read - Stable Storage size output.
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The output buffer to write to. * @buf: The output buffer to write to.
*/ */
static ssize_t pdcs_size_read(struct kobject *kobj, static ssize_t pdcs_size_read(struct kobject *kobj,
@ -528,6 +530,8 @@ static ssize_t pdcs_size_read(struct kobject *kobj,
/** /**
* pdcs_auto_read - Stable Storage autoboot/search flag output. * pdcs_auto_read - Stable Storage autoboot/search flag output.
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The output buffer to write to. * @buf: The output buffer to write to.
* @knob: The PF_AUTOBOOT or PF_AUTOSEARCH flag * @knob: The PF_AUTOBOOT or PF_AUTOSEARCH flag
*/ */
@ -554,6 +558,8 @@ static ssize_t pdcs_auto_read(struct kobject *kobj,
/** /**
* pdcs_autoboot_read - Stable Storage autoboot flag output. * pdcs_autoboot_read - Stable Storage autoboot flag output.
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The output buffer to write to. * @buf: The output buffer to write to.
*/ */
static ssize_t pdcs_autoboot_read(struct kobject *kobj, static ssize_t pdcs_autoboot_read(struct kobject *kobj,
@ -564,6 +570,8 @@ static ssize_t pdcs_autoboot_read(struct kobject *kobj,
/** /**
* pdcs_autosearch_read - Stable Storage autoboot flag output. * pdcs_autosearch_read - Stable Storage autoboot flag output.
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The output buffer to write to. * @buf: The output buffer to write to.
*/ */
static ssize_t pdcs_autosearch_read(struct kobject *kobj, static ssize_t pdcs_autosearch_read(struct kobject *kobj,
@ -574,6 +582,8 @@ static ssize_t pdcs_autosearch_read(struct kobject *kobj,
/** /**
* pdcs_timer_read - Stable Storage timer count output (in seconds). * pdcs_timer_read - Stable Storage timer count output (in seconds).
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The output buffer to write to. * @buf: The output buffer to write to.
* *
* The value of the timer field correponds to a number of seconds in powers of 2. * The value of the timer field correponds to a number of seconds in powers of 2.
@ -601,6 +611,8 @@ static ssize_t pdcs_timer_read(struct kobject *kobj,
/** /**
* pdcs_osid_read - Stable Storage OS ID register output. * pdcs_osid_read - Stable Storage OS ID register output.
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The output buffer to write to. * @buf: The output buffer to write to.
*/ */
static ssize_t pdcs_osid_read(struct kobject *kobj, static ssize_t pdcs_osid_read(struct kobject *kobj,
@ -619,6 +631,8 @@ static ssize_t pdcs_osid_read(struct kobject *kobj,
/** /**
* pdcs_osdep1_read - Stable Storage OS-Dependent data area 1 output. * pdcs_osdep1_read - Stable Storage OS-Dependent data area 1 output.
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The output buffer to write to. * @buf: The output buffer to write to.
* *
* This can hold 16 bytes of OS-Dependent data. * This can hold 16 bytes of OS-Dependent data.
@ -645,6 +659,8 @@ static ssize_t pdcs_osdep1_read(struct kobject *kobj,
/** /**
* pdcs_diagnostic_read - Stable Storage Diagnostic register output. * pdcs_diagnostic_read - Stable Storage Diagnostic register output.
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The output buffer to write to. * @buf: The output buffer to write to.
* *
* I have NFC how to interpret the content of that register ;-). * I have NFC how to interpret the content of that register ;-).
@ -669,6 +685,8 @@ static ssize_t pdcs_diagnostic_read(struct kobject *kobj,
/** /**
* pdcs_fastsize_read - Stable Storage FastSize register output. * pdcs_fastsize_read - Stable Storage FastSize register output.
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The output buffer to write to. * @buf: The output buffer to write to.
* *
* This register holds the amount of system RAM to be tested during boot sequence. * This register holds the amount of system RAM to be tested during boot sequence.
@ -697,6 +715,8 @@ static ssize_t pdcs_fastsize_read(struct kobject *kobj,
/** /**
* pdcs_osdep2_read - Stable Storage OS-Dependent data area 2 output. * pdcs_osdep2_read - Stable Storage OS-Dependent data area 2 output.
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The output buffer to write to. * @buf: The output buffer to write to.
* *
* This can hold pdcs_size - 224 bytes of OS-Dependent data, when available. * This can hold pdcs_size - 224 bytes of OS-Dependent data, when available.
@ -729,6 +749,8 @@ static ssize_t pdcs_osdep2_read(struct kobject *kobj,
/** /**
* pdcs_auto_write - This function handles autoboot/search flag modifying. * pdcs_auto_write - This function handles autoboot/search flag modifying.
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The input buffer to read from. * @buf: The input buffer to read from.
* @count: The number of bytes to be read. * @count: The number of bytes to be read.
* @knob: The PF_AUTOBOOT or PF_AUTOSEARCH flag * @knob: The PF_AUTOBOOT or PF_AUTOSEARCH flag
@ -801,6 +823,8 @@ static ssize_t pdcs_auto_write(struct kobject *kobj,
/** /**
* pdcs_autoboot_write - This function handles autoboot flag modifying. * pdcs_autoboot_write - This function handles autoboot flag modifying.
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The input buffer to read from. * @buf: The input buffer to read from.
* @count: The number of bytes to be read. * @count: The number of bytes to be read.
* *
@ -817,6 +841,8 @@ static ssize_t pdcs_autoboot_write(struct kobject *kobj,
/** /**
* pdcs_autosearch_write - This function handles autosearch flag modifying. * pdcs_autosearch_write - This function handles autosearch flag modifying.
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The input buffer to read from. * @buf: The input buffer to read from.
* @count: The number of bytes to be read. * @count: The number of bytes to be read.
* *
@ -833,6 +859,8 @@ static ssize_t pdcs_autosearch_write(struct kobject *kobj,
/** /**
* pdcs_osdep1_write - Stable Storage OS-Dependent data area 1 input. * pdcs_osdep1_write - Stable Storage OS-Dependent data area 1 input.
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The input buffer to read from. * @buf: The input buffer to read from.
* @count: The number of bytes to be read. * @count: The number of bytes to be read.
* *
@ -870,6 +898,8 @@ static ssize_t pdcs_osdep1_write(struct kobject *kobj,
/** /**
* pdcs_osdep2_write - Stable Storage OS-Dependent data area 2 input. * pdcs_osdep2_write - Stable Storage OS-Dependent data area 2 input.
* @kobj: The kobject used to share data with userspace.
* @attr: The kobject attributes.
* @buf: The input buffer to read from. * @buf: The input buffer to read from.
* @count: The number of bytes to be read. * @count: The number of bytes to be read.
* *
@ -1023,7 +1053,7 @@ pdcs_unregister_pathentries(void)
static int __init static int __init
pdc_stable_init(void) pdc_stable_init(void)
{ {
int rc = 0, error = 0; int rc = 0, error;
u32 result; u32 result;
/* find the size of the stable storage */ /* find the size of the stable storage */
@ -1052,6 +1082,10 @@ pdc_stable_init(void)
/* Don't forget the root entries */ /* Don't forget the root entries */
error = sysfs_create_group(stable_kobj, &pdcs_attr_group); error = sysfs_create_group(stable_kobj, &pdcs_attr_group);
if (error) {
rc = -ENOMEM;
goto fail_ksetreg;
}
/* register the paths kset as a child of the stable kset */ /* register the paths kset as a child of the stable kset */
paths_kset = kset_create_and_add("paths", NULL, stable_kobj); paths_kset = kset_create_and_add("paths", NULL, stable_kobj);