mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 04:47:05 +00:00
net: tcp: remove call to obsolete crypto_ahash_alignmask()
linux-next hit the following build error: net/ipv4/tcp_ao.c: In function 'tcp_ao_key_alloc': net/ipv4/tcp_ao.c:1536:13: error: implicit declaration of function 'crypto_ahash_alignmask'; did you mean 'crypto_ahash_alg_name'? [-Werror=implicit-function-declaration] 1536 | if (crypto_ahash_alignmask(tfm) > TCP_AO_KEY_ALIGN) { | ^~~~~~~~~~~~~~~~~~~~~~ | crypto_ahash_alg_name Caused by commit from the crypto tree0f8660c82b
("crypto: ahash - remove crypto_ahash_alignmask") interacting with commit4954f17dde
("net/tcp: Introduce TCP_AO setsockopt()s") from networking. crypto_ahash_alignmask() has been phased out by the former commit, drop the call in networking. Eric confirms that the check is safe to remove and was questionable here in the first place. Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Acked-by: Herbert Xu <herbert@gondor.apana.org.au> Reviewed-by: Dmitry Safonov <dima@arista.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
e0f9f0e073
commit
f2fbb90811
1 changed files with 0 additions and 6 deletions
|
@ -1533,10 +1533,6 @@ static struct tcp_ao_key *tcp_ao_key_alloc(struct sock *sk,
|
|||
goto err_free_pool;
|
||||
|
||||
tfm = crypto_ahash_reqtfm(hp.req);
|
||||
if (crypto_ahash_alignmask(tfm) > TCP_AO_KEY_ALIGN) {
|
||||
err = -EOPNOTSUPP;
|
||||
goto err_pool_end;
|
||||
}
|
||||
digest_size = crypto_ahash_digestsize(tfm);
|
||||
tcp_sigpool_end(&hp);
|
||||
|
||||
|
@ -1551,8 +1547,6 @@ static struct tcp_ao_key *tcp_ao_key_alloc(struct sock *sk,
|
|||
key->digest_size = digest_size;
|
||||
return key;
|
||||
|
||||
err_pool_end:
|
||||
tcp_sigpool_end(&hp);
|
||||
err_free_pool:
|
||||
tcp_sigpool_release(pool_id);
|
||||
return ERR_PTR(err);
|
||||
|
|
Loading…
Reference in a new issue