mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-06 08:46:46 +00:00
mlxsw: spectrum_qdisc: Ignore grafting of invisible FIFO
[ Upstream commit3971a535b8
] The following patch will change PRIO to replace a removed Qdisc with an invisible FIFO, instead of NOOP. mlxsw will see this replacement due to the graft message that is generated. But because FIFO does not issue its own REPLACE message, when the graft operation takes place, the Qdisc that mlxsw tracks under the indicated band is still the old one. The child handle (0:0) therefore does not match, and mlxsw rejects the graft operation, which leads to an extack message: Warning: Offloading graft operation failed. Fix by ignoring the invisible children in the PRIO graft handler. The DESTROY message of the removed Qdisc is going to follow shortly and handle the removal. Fixes:32dc5efc6c
("mlxsw: spectrum: qdiscs: prio: Handle graft command") Signed-off-by: Petr Machata <petrm@mellanox.com> Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
a44ed37804
commit
f39007afe7
1 changed files with 7 additions and 0 deletions
|
@ -650,6 +650,13 @@ mlxsw_sp_qdisc_prio_graft(struct mlxsw_sp_port *mlxsw_sp_port,
|
||||||
mlxsw_sp_port->tclass_qdiscs[tclass_num].handle == p->child_handle)
|
mlxsw_sp_port->tclass_qdiscs[tclass_num].handle == p->child_handle)
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
|
if (!p->child_handle) {
|
||||||
|
/* This is an invisible FIFO replacing the original Qdisc.
|
||||||
|
* Ignore it--the original Qdisc's destroy will follow.
|
||||||
|
*/
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
/* See if the grafted qdisc is already offloaded on any tclass. If so,
|
/* See if the grafted qdisc is already offloaded on any tclass. If so,
|
||||||
* unoffload it.
|
* unoffload it.
|
||||||
*/
|
*/
|
||||||
|
|
Loading…
Reference in a new issue