mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-11-01 00:48:50 +00:00
Code Issues Releases Wiki Activity

drivers/base/memory: fix an unlikely reference counting issue in __add_memory_block()

Browse source 
__add_memory_block() calls both put_device() and device_unregister() when
storing the memory block into the xarray.  This is incorrect because
xarray doesn't take an additional reference and device_unregister()
already calls put_device().

Triggering the issue looks really unlikely and its only effect should be
to log a spurious warning about a ref counted issue.

Link: https://lkml.kernel.org/r/d44c63d78affe844f020dc02ad6af29abc448fc4.1650611702.git.christophe.jaillet@wanadoo.fr
Fixes: 4fb6eabf10 ("drivers/base/memory.c: cache memory blocks in xarray to accelerate lookup")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Scott Cheloha <cheloha@linux.vnet.ibm.com>
Cc: Nathan Lynch <nathanl@linux.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Christophe JAILLET 2022-04-28 23:16:19 -07:00 committed by akpm
parent ca2864e52d
commit f47f758cff
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/base/memory.c
View file

@ -636,10 +636,9 @@ static int __add_memory_block(struct memory_block *memory)
} }
ret = xa_err(xa_store(&memory_blocks, memory->dev.id, memory, ret = xa_err(xa_store(&memory_blocks, memory->dev.id, memory,
GFP_KERNEL)); GFP_KERNEL));
if (ret) { if (ret)
put_device(&memory->dev);
device_unregister(&memory->dev); device_unregister(&memory->dev);
}
return ret; return ret;
} }