vdpa_sim: reset must not run
[ Upstream commit9588e7fc51
] vdpasim_do_reset sets running to true, which is wrong, as it allows vdpasim_kick_vq to post work requests before the device has been configured. To fix, do not set running until VIRTIO_CONFIG_S_DRIVER_OK is set. Fixes:0c89e2a3a9
("vdpa_sim: Implement suspend vdpa op") Signed-off-by: Steve Sistare <steven.sistare@oracle.com> Reviewed-by: Eugenio Pérez <eperezma@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> Message-Id: <1707517807-137331-1-git-send-email-steven.sistare@oracle.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
ac266cbfbc
commit
f5f6085a03
|
@ -160,7 +160,7 @@ static void vdpasim_do_reset(struct vdpasim *vdpasim, u32 flags)
|
|||
}
|
||||
}
|
||||
|
||||
vdpasim->running = true;
|
||||
vdpasim->running = false;
|
||||
spin_unlock(&vdpasim->iommu_lock);
|
||||
|
||||
vdpasim->features = 0;
|
||||
|
@ -483,6 +483,7 @@ static void vdpasim_set_status(struct vdpa_device *vdpa, u8 status)
|
|||
|
||||
mutex_lock(&vdpasim->mutex);
|
||||
vdpasim->status = status;
|
||||
vdpasim->running = (status & VIRTIO_CONFIG_S_DRIVER_OK) != 0;
|
||||
mutex_unlock(&vdpasim->mutex);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue