mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-06 00:39:48 +00:00
qla4xxx: Fix memory leak for ha->saved_acb
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
parent
906cbf3d2c
commit
f65241e729
1 changed files with 4 additions and 2 deletions
|
@ -2395,8 +2395,6 @@ int qla4_84xx_config_acb(struct scsi_qla_host *ha, int acb_config)
|
|||
}
|
||||
|
||||
memcpy(acb, ha->saved_acb, acb_len);
|
||||
kfree(ha->saved_acb);
|
||||
ha->saved_acb = NULL;
|
||||
|
||||
rval = qla4xxx_set_acb(ha, &mbox_cmd[0], &mbox_sts[0], acb_dma);
|
||||
if (rval != QLA_SUCCESS)
|
||||
|
@ -2412,6 +2410,10 @@ int qla4_84xx_config_acb(struct scsi_qla_host *ha, int acb_config)
|
|||
dma_free_coherent(&ha->pdev->dev, sizeof(struct addr_ctrl_blk), acb,
|
||||
acb_dma);
|
||||
exit_config_acb:
|
||||
if ((acb_config == ACB_CONFIG_SET) && ha->saved_acb) {
|
||||
kfree(ha->saved_acb);
|
||||
ha->saved_acb = NULL;
|
||||
}
|
||||
DEBUG2(ql4_printk(KERN_INFO, ha,
|
||||
"%s %s\n", __func__,
|
||||
rval == QLA_SUCCESS ? "SUCCEEDED" : "FAILED"));
|
||||
|
|
Loading…
Reference in a new issue