mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 01:10:04 +00:00
[netdrvr] natsemi: Fix device removal bug
This episode illustrates how an overused warning can train people to ignore that warning, which winds up hiding bugs. The warning drivers/net/natsemi.c: In function ‘natsemi_remove1’: drivers/net/natsemi.c:3222: warning: ignoring return value of ‘device_create_file’, declared with attribute warn_unused_result is oft-ignored, even though at close inspection one notices this occurs in the /remove/ function, not normally where creation occurs. A quick s/create/remove/ and we are fixed, with the warning gone. Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
parent
6f686d3d14
commit
f6c4286590
1 changed files with 1 additions and 1 deletions
|
@ -671,7 +671,7 @@ static ssize_t natsemi_show_##_name(struct device *dev, \
|
|||
#define NATSEMI_CREATE_FILE(_dev, _name) \
|
||||
device_create_file(&_dev->dev, &dev_attr_##_name)
|
||||
#define NATSEMI_REMOVE_FILE(_dev, _name) \
|
||||
device_create_file(&_dev->dev, &dev_attr_##_name)
|
||||
device_remove_file(&_dev->dev, &dev_attr_##_name)
|
||||
|
||||
NATSEMI_ATTR(dspcfg_workaround);
|
||||
|
||||
|
|
Loading…
Reference in a new issue