mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity

usb: common: Simplify usb_decode_get_set_descriptor function. 

Patch moves switch responsible for decoding descriptor type
outside snprintf. It improves code readability a little.

Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
This commit is contained in:
Pawel Laszczak 2019-08-26 12:19:29 +01:00 committed by Felipe Balbi
parent 010665b44d
commit f72429fc88
1 changed files with 58 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/usb/common/debug.c
View File

@ -105,9 +105,8 @@ static void usb_decode_get_set_descriptor(__u8 bRequestType, __u8 bRequest,
__u16 wValue, __u16 wIndex,
__u16 wLength, char *str, size_t size)
{
snprintf(str, size, "%s %s Descriptor(Index = %d, Length = %d)",
bRequest == USB_REQ_GET_DESCRIPTOR ? "Get" : "Set",
({ char *s;
char *s;
switch (wValue >> 8) {
case USB_DT_DEVICE:
s = "Device";
@ -160,7 +159,11 @@ static void usb_decode_get_set_descriptor(__u8 bRequestType, __u8 bRequest,
default:
s = "UNKNOWN";
break;
} s; }), wValue & 0xff, wLength);
}
snprintf(str, size, "%s %s Descriptor(Index = %d, Length = %d)",
bRequest == USB_REQ_GET_DESCRIPTOR ? "Get" : "Set",
s, wValue & 0xff, wLength);
}
static void usb_decode_get_configuration(__u16 wLength, char *str, size_t size)