mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-26 12:26:11 +00:00
ipmi: fix use after free in _ipmi_destroy_user()
commita92ce570c8
upstream. The intf_free() function frees the "intf" pointer so we cannot dereference it again on the next line. Fixes:cbb79863fc
("ipmi: Don't allow device module unload when in use") Signed-off-by: Dan Carpenter <error27@gmail.com> Message-Id: <Y3M8xa1drZv4CToE@kili> Cc: <stable@vger.kernel.org> # 5.5+ Signed-off-by: Corey Minyard <cminyard@mvista.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
2ec49bc525
commit
f7fde44119
1 changed files with 3 additions and 1 deletions
|
@ -1336,6 +1336,7 @@ static void _ipmi_destroy_user(struct ipmi_user *user)
|
||||||
unsigned long flags;
|
unsigned long flags;
|
||||||
struct cmd_rcvr *rcvr;
|
struct cmd_rcvr *rcvr;
|
||||||
struct cmd_rcvr *rcvrs = NULL;
|
struct cmd_rcvr *rcvrs = NULL;
|
||||||
|
struct module *owner;
|
||||||
|
|
||||||
if (!acquire_ipmi_user(user, &i)) {
|
if (!acquire_ipmi_user(user, &i)) {
|
||||||
/*
|
/*
|
||||||
|
@ -1398,8 +1399,9 @@ static void _ipmi_destroy_user(struct ipmi_user *user)
|
||||||
kfree(rcvr);
|
kfree(rcvr);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
owner = intf->owner;
|
||||||
kref_put(&intf->refcount, intf_free);
|
kref_put(&intf->refcount, intf_free);
|
||||||
module_put(intf->owner);
|
module_put(owner);
|
||||||
}
|
}
|
||||||
|
|
||||||
int ipmi_destroy_user(struct ipmi_user *user)
|
int ipmi_destroy_user(struct ipmi_user *user)
|
||||||
|
|
Loading…
Reference in a new issue