mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-04 08:08:54 +00:00
drm/tegra: hub: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Thierry Reding <treding@nvidia.com>
This commit is contained in:
parent
4ef19206b2
commit
f9998eef32
1 changed files with 2 additions and 4 deletions
|
@ -1174,7 +1174,7 @@ static int tegra_display_hub_probe(struct platform_device *pdev)
|
|||
return err;
|
||||
}
|
||||
|
||||
static int tegra_display_hub_remove(struct platform_device *pdev)
|
||||
static void tegra_display_hub_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct tegra_display_hub *hub = platform_get_drvdata(pdev);
|
||||
unsigned int i;
|
||||
|
@ -1188,8 +1188,6 @@ static int tegra_display_hub_remove(struct platform_device *pdev)
|
|||
}
|
||||
|
||||
pm_runtime_disable(&pdev->dev);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct tegra_display_hub_soc tegra186_display_hub = {
|
||||
|
@ -1221,5 +1219,5 @@ struct platform_driver tegra_display_hub_driver = {
|
|||
.of_match_table = tegra_display_hub_of_match,
|
||||
},
|
||||
.probe = tegra_display_hub_probe,
|
||||
.remove = tegra_display_hub_remove,
|
||||
.remove_new = tegra_display_hub_remove,
|
||||
};
|
||||
|
|
Loading…
Reference in a new issue