usb: misc: onboard_usb_hub: Disable the USB hub clock on failure
commit34b990e9bb
upstream. In case regulator_bulk_enable() fails, the previously enabled USB hub clock should be disabled. Fix it accordingly. Fixes:65e62b8a95
("usb: misc: onboard_usb_hub: Add support for clock input") Cc: stable <stable@kernel.org> Signed-off-by: Fabio Estevam <festevam@denx.de> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> Acked-by: Matthias Kaehlcke <mka@chromium.org> Link: https://lore.kernel.org/r/20240409162910.2061640-1-festevam@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
026e1f08bd
commit
fa5590c416
|
@ -78,7 +78,7 @@ static int onboard_hub_power_on(struct onboard_hub *hub)
|
|||
err = regulator_bulk_enable(hub->pdata->num_supplies, hub->supplies);
|
||||
if (err) {
|
||||
dev_err(hub->dev, "failed to enable supplies: %pe\n", ERR_PTR(err));
|
||||
return err;
|
||||
goto disable_clk;
|
||||
}
|
||||
|
||||
fsleep(hub->pdata->reset_us);
|
||||
|
@ -87,6 +87,10 @@ static int onboard_hub_power_on(struct onboard_hub *hub)
|
|||
hub->is_powered_on = true;
|
||||
|
||||
return 0;
|
||||
|
||||
disable_clk:
|
||||
clk_disable_unprepare(hub->clk);
|
||||
return err;
|
||||
}
|
||||
|
||||
static int onboard_hub_power_off(struct onboard_hub *hub)
|
||||
|
|
Loading…
Reference in New Issue