mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-29 20:30:35 +00:00
iwlegacy: avoid -Wempty-body warning
There are a couple of warnings in this driver when building with W=1: drivers/net/wireless/intel/iwlegacy/common.c: In function 'il_power_set_mode': drivers/net/wireless/intel/iwlegacy/common.c:1195:60: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] 1195 | il->chain_noise_data.state); | ^ drivers/net/wireless/intel/iwlegacy/common.c: In function 'il_do_scan_abort': drivers/net/wireless/intel/iwlegacy/common.c:1343:57: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body] Change the empty debug macros to no_printk(), which avoids the warnings and adds useful format string checks. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Stanislaw Gruszka <stf_xl@wp.pl> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/20210322104343.948660-3-arnd@kernel.org
This commit is contained in:
parent
670d9e5388
commit
fa9f5d0e0b
3 changed files with 1 additions and 5 deletions
|
@ -751,9 +751,7 @@ il3945_hdl_alive(struct il_priv *il, struct il_rx_buf *rxb)
|
|||
static void
|
||||
il3945_hdl_add_sta(struct il_priv *il, struct il_rx_buf *rxb)
|
||||
{
|
||||
#ifdef CONFIG_IWLEGACY_DEBUG
|
||||
struct il_rx_pkt *pkt = rxb_addr(rxb);
|
||||
#endif
|
||||
|
||||
D_RX("Received C_ADD_STA: 0x%02X\n", pkt->u.status);
|
||||
}
|
||||
|
|
|
@ -1430,10 +1430,8 @@ static void
|
|||
il_hdl_scan_complete(struct il_priv *il, struct il_rx_buf *rxb)
|
||||
{
|
||||
|
||||
#ifdef CONFIG_IWLEGACY_DEBUG
|
||||
struct il_rx_pkt *pkt = rxb_addr(rxb);
|
||||
struct il_scancomplete_notification *scan_notif = (void *)pkt->u.raw;
|
||||
#endif
|
||||
|
||||
D_SCAN("Scan complete: %d channels (TSF 0x%08X:%08X) - %d\n",
|
||||
scan_notif->scanned_channels, scan_notif->tsf_low,
|
||||
|
|
|
@ -2937,7 +2937,7 @@ do { \
|
|||
} while (0)
|
||||
|
||||
#else
|
||||
#define IL_DBG(level, fmt, args...)
|
||||
#define IL_DBG(level, fmt, args...) no_printk(fmt, ##args)
|
||||
static inline void
|
||||
il_print_hex_dump(struct il_priv *il, int level, const void *p, u32 len)
|
||||
{
|
||||
|
|
Loading…
Reference in a new issue