mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-05 10:29:37 +00:00
Code Issues Releases Wiki Activity

coresight: Document error handling in coresight_register

Browse source 
commit 6403587a930c ("coresight: use put_device() instead of kfree()")
fixes the double freeing of resources and ensures that the device
refcount is dropped properly. Add a comment to explain this to
help the readers and prevent people trying to "unfix" it again.

While at it, rename the labels for better readability.

Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Suzuki K Poulose 2018-09-20 13:17:36 -06:00 committed by Greg Kroah-Hartman
parent b31bd669b4
commit fac253e52f
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
drivers/hwtracing/coresight/coresight.c
View file

@ -1006,7 +1006,7 @@ struct coresight_device *coresight_register(struct coresight_desc *desc)
csdev = kzalloc(sizeof(*csdev), GFP_KERNEL);
if (!csdev) {
ret = -ENOMEM;
goto err_kzalloc_csdev;
goto err_out;
}
if (desc->type == CORESIGHT_DEV_TYPE_LINK ||
@ -1022,7 +1022,7 @@ struct coresight_device *coresight_register(struct coresight_desc *desc)
refcnts = kcalloc(nr_refcnts, sizeof(*refcnts), GFP_KERNEL);
if (!refcnts) {
ret = -ENOMEM;
goto err_kzalloc_refcnts;
goto err_free_csdev;
}
csdev->refcnt = refcnts;
@ -1035,7 +1035,7 @@ struct coresight_device *coresight_register(struct coresight_desc *desc)
conns = kcalloc(csdev->nr_outport, sizeof(*conns), GFP_KERNEL);
if (!conns) {
ret = -ENOMEM;
goto err_kzalloc_conns;
goto err_free_refcnts;
}
for (i = 0; i < csdev->nr_outport; i++) {
@ -1062,7 +1062,11 @@ struct coresight_device *coresight_register(struct coresight_desc *desc)
ret = device_register(&csdev->dev);
if (ret) {
put_device(&csdev->dev);
goto err_kzalloc_csdev;
/*
* All resources are free'd explicitly via
* coresight_device_release(), triggered from put_device().
*/
goto err_out;
}
mutex_lock(&coresight_mutex);
@ -1074,11 +1078,11 @@ struct coresight_device *coresight_register(struct coresight_desc *desc)
return csdev;
err_kzalloc_conns:
err_free_refcnts:
kfree(refcnts);
err_kzalloc_refcnts:
err_free_csdev:
kfree(csdev);
err_kzalloc_csdev:
err_out:
return ERR_PTR(ret);
}
EXPORT_SYMBOL_GPL(coresight_register);