mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-02 15:18:19 +00:00
Code Issues Releases Wiki Activity

HID: input: Fix NULL pointer dereference when power_supply_register fails

Browse source 
Do not call power_supply_powers() if power_supply_register() failed
earlier. This fixes possible NULL pointer dereference by
power_supply_powers() in such case.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
This commit is contained in:
Krzysztof Kozlowski 2015-03-23 16:34:51 +01:00 committed by Sebastian Reichel
parent 8fb0885504
commit fbea947c7d
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/hid/hid-input.c
View file

@ -452,10 +452,10 @@ static bool hidinput_setup_battery(struct hid_device *dev, unsigned report_type,
kfree(psy_desc->name); kfree(psy_desc->name);
kfree(psy_desc); kfree(psy_desc);
dev->battery = NULL; dev->battery = NULL;
} else {
power_supply_powers(dev->battery, &dev->dev);
} }
power_supply_powers(dev->battery, &dev->dev);
out: out:
return true; return true;
} }