mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-30 16:07:39 +00:00
enic: cleanup vic_provinfo_alloc()
If oui were a null variable then vic_provinfo_alloc() would leak memory. But this function is only called from one place and oui is not null so I removed the check. I also moved the memory allocation down a line so it was easier to spot. (No one ever reads variable declarations). Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
62522d36d7
commit
fc0ba8e871
1 changed files with 3 additions and 2 deletions
|
@ -25,9 +25,10 @@
|
|||
|
||||
struct vic_provinfo *vic_provinfo_alloc(gfp_t flags, u8 *oui, u8 type)
|
||||
{
|
||||
struct vic_provinfo *vp = kzalloc(VIC_PROVINFO_MAX_DATA, flags);
|
||||
struct vic_provinfo *vp;
|
||||
|
||||
if (!vp || !oui)
|
||||
vp = kzalloc(VIC_PROVINFO_MAX_DATA, flags);
|
||||
if (!vp)
|
||||
return NULL;
|
||||
|
||||
memcpy(vp->oui, oui, sizeof(vp->oui));
|
||||
|
|
Loading…
Reference in a new issue