mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 11:19:37 +00:00
qed: Prevent MF link notifications
When device is configured for Multi-function mode, some older management firmware might incorrectly notify interfaces of link changes while they haven't requested the physical link configuration to be set. This can create bizzare race conditions where unloading interfaces are getting notified that the link is up. Let the driver compensate - store the logical requested state of the link and don't propagate notifications after protocol driver explicitly requires the link to be unset. Signed-off-by: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com> Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
627caa9d31
commit
fc916ff202
2 changed files with 9 additions and 1 deletions
|
@ -303,6 +303,9 @@ struct qed_hwfn {
|
||||||
bool b_int_enabled;
|
bool b_int_enabled;
|
||||||
bool b_int_requested;
|
bool b_int_requested;
|
||||||
|
|
||||||
|
/* True if the driver requests for the link */
|
||||||
|
bool b_drv_link_init;
|
||||||
|
|
||||||
struct qed_mcp_info *mcp_info;
|
struct qed_mcp_info *mcp_info;
|
||||||
|
|
||||||
struct qed_hw_cid_data *p_tx_cids;
|
struct qed_hw_cid_data *p_tx_cids;
|
||||||
|
|
|
@ -390,7 +390,10 @@ static void qed_mcp_handle_link_change(struct qed_hwfn *p_hwfn,
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
p_link->link_up = !!(status & LINK_STATUS_LINK_UP);
|
if (p_hwfn->b_drv_link_init)
|
||||||
|
p_link->link_up = !!(status & LINK_STATUS_LINK_UP);
|
||||||
|
else
|
||||||
|
p_link->link_up = false;
|
||||||
|
|
||||||
p_link->full_duplex = true;
|
p_link->full_duplex = true;
|
||||||
switch ((status & LINK_STATUS_SPEED_AND_DUPLEX_MASK)) {
|
switch ((status & LINK_STATUS_SPEED_AND_DUPLEX_MASK)) {
|
||||||
|
@ -520,6 +523,8 @@ int qed_mcp_set_link(struct qed_hwfn *p_hwfn,
|
||||||
offsetof(struct public_drv_mb, union_data) + i,
|
offsetof(struct public_drv_mb, union_data) + i,
|
||||||
((u32 *)&phy_cfg)[i >> 2]);
|
((u32 *)&phy_cfg)[i >> 2]);
|
||||||
|
|
||||||
|
p_hwfn->b_drv_link_init = b_up;
|
||||||
|
|
||||||
if (b_up) {
|
if (b_up) {
|
||||||
DP_VERBOSE(p_hwfn, NETIF_MSG_LINK,
|
DP_VERBOSE(p_hwfn, NETIF_MSG_LINK,
|
||||||
"Configuring Link: Speed 0x%08x, Pause 0x%08x, adv_speed 0x%08x, loopback 0x%08x, features 0x%08x\n",
|
"Configuring Link: Speed 0x%08x, Pause 0x%08x, adv_speed 0x%08x, loopback 0x%08x, features 0x%08x\n",
|
||||||
|
|
Loading…
Reference in a new issue