mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-03 17:40:04 +00:00
rtnetlink: fix error return code in rtnl_link_fill()
Fix to return a negative error code from the error handling case instead of 0(possible overwrite to 0 by ops->fill_xstats call), as returned elsewhere in this function. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
14109a59ca
commit
fcca143d69
1 changed files with 3 additions and 1 deletions
|
@ -496,8 +496,10 @@ static int rtnl_link_fill(struct sk_buff *skb, const struct net_device *dev)
|
|||
}
|
||||
if (ops->fill_info) {
|
||||
data = nla_nest_start(skb, IFLA_INFO_DATA);
|
||||
if (data == NULL)
|
||||
if (data == NULL) {
|
||||
err = -EMSGSIZE;
|
||||
goto err_cancel_link;
|
||||
}
|
||||
err = ops->fill_info(skb, dev);
|
||||
if (err < 0)
|
||||
goto err_cancel_data;
|
||||
|
|
Loading…
Reference in a new issue