mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 22:54:01 +00:00
mm/rmap: drop stale comment in page_add_anon_rmap and hugepage_add_anon_rmap()
Patch series "Anon rmap cleanups". Some cleanups around rmap for anon pages. I'm working on more cleanups also around file rmap -- also to handle the "compound" parameter internally only and to let hugetlb use page_add_file_rmap(), but these changes make sense separately. This patch (of 6): That comment was added in commit5dbe0af47f
("mm: fix kernel BUG at mm/rmap.c:1017!") to document why we can see vma->vm_end getting adjusted concurrently due to a VMA split. However, the optimized locking code was changed again inbf181b9f9d
("mm anon rmap: replace same_anon_vma linked list with an interval tree."). ... and later, the comment was changed in commit0503ea8f5b
("mm/mmap: remove __vma_adjust()") to talk about "vma_merge" although the original issue was with VMA splitting. Let's just remove that comment. Nowadays, it's outdated, imprecise and confusing. Link: https://lkml.kernel.org/r/20230913125113.313322-1-david@redhat.com Link: https://lkml.kernel.org/r/20230913125113.313322-2-david@redhat.com Signed-off-by: David Hildenbrand <david@redhat.com> Cc: Mike Kravetz <mike.kravetz@oracle.com> Cc: Muchun Song <muchun.song@linux.dev> Cc: Matthew Wilcox <willy@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
parent
811244a501
commit
fd63908706
1 changed files with 0 additions and 2 deletions
|
@ -1245,7 +1245,6 @@ void page_add_anon_rmap(struct page *page, struct vm_area_struct *vma,
|
||||||
__lruvec_stat_mod_folio(folio, NR_ANON_MAPPED, nr);
|
__lruvec_stat_mod_folio(folio, NR_ANON_MAPPED, nr);
|
||||||
|
|
||||||
if (likely(!folio_test_ksm(folio))) {
|
if (likely(!folio_test_ksm(folio))) {
|
||||||
/* address might be in next vma when migration races vma_merge */
|
|
||||||
if (first)
|
if (first)
|
||||||
__page_set_anon_rmap(folio, page, vma, address,
|
__page_set_anon_rmap(folio, page, vma, address,
|
||||||
!!(flags & RMAP_EXCLUSIVE));
|
!!(flags & RMAP_EXCLUSIVE));
|
||||||
|
@ -2549,7 +2548,6 @@ void hugepage_add_anon_rmap(struct page *page, struct vm_area_struct *vma,
|
||||||
|
|
||||||
BUG_ON(!folio_test_locked(folio));
|
BUG_ON(!folio_test_locked(folio));
|
||||||
BUG_ON(!anon_vma);
|
BUG_ON(!anon_vma);
|
||||||
/* address might be in next vma when migration races vma_merge */
|
|
||||||
first = atomic_inc_and_test(&folio->_entire_mapcount);
|
first = atomic_inc_and_test(&folio->_entire_mapcount);
|
||||||
VM_BUG_ON_PAGE(!first && (flags & RMAP_EXCLUSIVE), page);
|
VM_BUG_ON_PAGE(!first && (flags & RMAP_EXCLUSIVE), page);
|
||||||
VM_BUG_ON_PAGE(!first && PageAnonExclusive(page), page);
|
VM_BUG_ON_PAGE(!first && PageAnonExclusive(page), page);
|
||||||
|
|
Loading…
Reference in a new issue