mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 08:19:28 +00:00
[PATCH] x86_64: Don't do broadcast IPIs when hotplug is enabled in flat mode.
The use of non-shortcut version of routines breaking CPU hotplug. The option to select this via cmdline also is deleted with the physflat patch, hence directly placing this code under CONFIG_HOTPLUG_CPU. We dont want to use broadcast mode IPI's when hotplug is enabled. This causes bad effects in send IPI to a cpu that is offline which can trip when the cpu is in the process of being kicked alive. Signed-off-by: Ashok Raj <ashok.raj@intel.com> Acked-by: Andi Kleen <ak@muc.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
4c7fc7220f
commit
fdf26d933a
1 changed files with 10 additions and 0 deletions
|
@ -78,8 +78,18 @@ static void flat_send_IPI_mask(cpumask_t cpumask, int vector)
|
|||
|
||||
static void flat_send_IPI_allbutself(int vector)
|
||||
{
|
||||
#ifndef CONFIG_HOTPLUG_CPU
|
||||
if (((num_online_cpus()) - 1) >= 1)
|
||||
__send_IPI_shortcut(APIC_DEST_ALLBUT, vector,APIC_DEST_LOGICAL);
|
||||
#else
|
||||
cpumask_t allbutme = cpu_online_map;
|
||||
int me = get_cpu(); /* Ensure we are not preempted when we clear */
|
||||
cpu_clear(me, allbutme);
|
||||
|
||||
if (!cpus_empty(allbutme))
|
||||
flat_send_IPI_mask(allbutme, vector);
|
||||
put_cpu();
|
||||
#endif
|
||||
}
|
||||
|
||||
static void flat_send_IPI_all(int vector)
|
||||
|
|
Loading…
Reference in a new issue