mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-07 03:18:31 +00:00
ecryptfs: fix a memory leak bug in parse_tag_1_packet()
In parse_tag_1_packet(), if tag 1 packet contains a key larger than
ECRYPTFS_MAX_ENCRYPTED_KEY_BYTES, no cleanup is executed, leading to a
memory leak on the allocated 'auth_tok_list_item'. To fix this issue, go to
the label 'out_free' to perform the cleanup work.
Cc: stable@vger.kernel.org
Fixes: dddfa461fc
("[PATCH] eCryptfs: Public key; packet management")
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
This commit is contained in:
parent
5f97cbe22b
commit
fe2e082f5d
1 changed files with 1 additions and 1 deletions
|
@ -1304,7 +1304,7 @@ parse_tag_1_packet(struct ecryptfs_crypt_stat *crypt_stat,
|
||||||
printk(KERN_WARNING "Tag 1 packet contains key larger "
|
printk(KERN_WARNING "Tag 1 packet contains key larger "
|
||||||
"than ECRYPTFS_MAX_ENCRYPTED_KEY_BYTES\n");
|
"than ECRYPTFS_MAX_ENCRYPTED_KEY_BYTES\n");
|
||||||
rc = -EINVAL;
|
rc = -EINVAL;
|
||||||
goto out;
|
goto out_free;
|
||||||
}
|
}
|
||||||
memcpy((*new_auth_tok)->session_key.encrypted_key,
|
memcpy((*new_auth_tok)->session_key.encrypted_key,
|
||||||
&data[(*packet_size)], (body_size - (ECRYPTFS_SIG_SIZE + 2)));
|
&data[(*packet_size)], (body_size - (ECRYPTFS_SIG_SIZE + 2)));
|
||||||
|
|
Loading…
Reference in a new issue