mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 13:55:32 +00:00
staging: bcm2835-camera: Correct V4L2_CID_COLORFX_CBCR behaviour
With V4L2_CID_COLORFX_CBCR calling ctrl_set_colfx it was incorrectly assigning the colour values to the enable field of dev->colourfx instead of the u and v fields. Correct the assignments. Reported as a Coverity issue Detected by CoverityScan CID#1419711 ("Unused value") Reported-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Signed-off-by: Stefan Wahren <wahrenst@gmx.net> Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
ed5fea7a78
commit
fe8adc4123
1 changed files with 2 additions and 2 deletions
|
@ -574,8 +574,8 @@ static int ctrl_set_colfx(struct bm2835_mmal_dev *dev,
|
|||
|
||||
control = &dev->component[COMP_CAMERA]->control;
|
||||
|
||||
dev->colourfx.enable = (ctrl->val & 0xff00) >> 8;
|
||||
dev->colourfx.enable = ctrl->val & 0xff;
|
||||
dev->colourfx.u = (ctrl->val & 0xff00) >> 8;
|
||||
dev->colourfx.v = ctrl->val & 0xff;
|
||||
|
||||
ret = vchiq_mmal_port_parameter_set(dev->instance, control,
|
||||
MMAL_PARAMETER_COLOUR_EFFECT,
|
||||
|
|
Loading…
Reference in a new issue