mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 06:33:07 +00:00
tty: ipwireless, cleanup TIOCGSERIAL
In ipwireless_get_serial_info, struct serial_struct is memset to 0 and then some members set to 0 explicitly. Remove the latter as it is obviously superfluous. And remove the retinfo check against NULL. copy_to_user will take care of that. Part of hub6 cleanup series. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Jiri Kosina <jikos@kernel.org> Acked-by: David Sterba <dsterba@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
33688abb28
commit
fec4daecad
1 changed files with 1 additions and 10 deletions
|
@ -252,20 +252,11 @@ static int ipwireless_get_serial_info(struct ipw_tty *tty,
|
||||||
{
|
{
|
||||||
struct serial_struct tmp;
|
struct serial_struct tmp;
|
||||||
|
|
||||||
if (!retinfo)
|
|
||||||
return (-EFAULT);
|
|
||||||
|
|
||||||
memset(&tmp, 0, sizeof(tmp));
|
memset(&tmp, 0, sizeof(tmp));
|
||||||
tmp.type = PORT_UNKNOWN;
|
tmp.type = PORT_UNKNOWN;
|
||||||
tmp.line = tty->index;
|
tmp.line = tty->index;
|
||||||
tmp.port = 0;
|
|
||||||
tmp.irq = 0;
|
|
||||||
tmp.flags = 0;
|
|
||||||
tmp.baud_base = 115200;
|
tmp.baud_base = 115200;
|
||||||
tmp.close_delay = 0;
|
|
||||||
tmp.closing_wait = 0;
|
|
||||||
tmp.custom_divisor = 0;
|
|
||||||
tmp.hub6 = 0;
|
|
||||||
if (copy_to_user(retinfo, &tmp, sizeof(*retinfo)))
|
if (copy_to_user(retinfo, &tmp, sizeof(*retinfo)))
|
||||||
return -EFAULT;
|
return -EFAULT;
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue