mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 14:44:12 +00:00
slimbus: qcom: Fix return value check in qcom_slim_probe()
In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
f8d2c8ea57
commit
ff595a3348
1 changed files with 2 additions and 2 deletions
|
@ -529,9 +529,9 @@ static int qcom_slim_probe(struct platform_device *pdev)
|
||||||
|
|
||||||
slim_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ctrl");
|
slim_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ctrl");
|
||||||
ctrl->base = devm_ioremap_resource(ctrl->dev, slim_mem);
|
ctrl->base = devm_ioremap_resource(ctrl->dev, slim_mem);
|
||||||
if (!ctrl->base) {
|
if (IS_ERR(ctrl->base)) {
|
||||||
dev_err(&pdev->dev, "IOremap failed\n");
|
dev_err(&pdev->dev, "IOremap failed\n");
|
||||||
return -ENOMEM;
|
return PTR_ERR(ctrl->base);
|
||||||
}
|
}
|
||||||
|
|
||||||
sctrl->set_laddr = qcom_set_laddr;
|
sctrl->set_laddr = qcom_set_laddr;
|
||||||
|
|
Loading…
Reference in a new issue