mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-01 22:54:01 +00:00
Code Issues Releases Wiki Activity

staging: rtl8723bs: remove redundant comparisons of unsigned ints with >= 0

Browse source 
The comparison of mode >= 0 is redundant as mode is a u32 and this
is always true.  Remove this redundant code.

Detected with CoverityScan ("Unsigned compared against 0")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Colin Ian King 2017-04-13 15:13:46 +01:00 committed by Greg Kroah-Hartman
parent baa7a586b5
commit ff8d351d71
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/staging/rtl8723bs/core/rtw_debug.c
View file

@ -1031,7 +1031,7 @@ ssize_t proc_set_ht_enable(struct file *file, const char __user *buffer, size_t
if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) { if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) {
sscanf(tmp, "%d ", &mode); sscanf(tmp, "%d ", &mode);
if (pregpriv && mode >= 0 && mode < 2) { if (pregpriv && mode < 2) {
pregpriv->ht_enable = mode; pregpriv->ht_enable = mode;
printk("ht_enable =%d\n", pregpriv->ht_enable); printk("ht_enable =%d\n", pregpriv->ht_enable);
} }
@ -1150,7 +1150,7 @@ ssize_t proc_set_rx_ampdu(struct file *file, const char __user *buffer, size_t c
sscanf(tmp, "%d ", &mode); sscanf(tmp, "%d ", &mode);
if (pregpriv && mode >= 0 && mode < 2) { if (pregpriv && mode < 2) {
pmlmeinfo->bAcceptAddbaReq = mode; pmlmeinfo->bAcceptAddbaReq = mode;
DBG_871X("pmlmeinfo->bAcceptAddbaReq =%d\n", pmlmeinfo->bAcceptAddbaReq); DBG_871X("pmlmeinfo->bAcceptAddbaReq =%d\n", pmlmeinfo->bAcceptAddbaReq);
if (mode == 0) { if (mode == 0) {
@ -1191,7 +1191,7 @@ ssize_t proc_set_en_fwps(struct file *file, const char __user *buffer, size_t co
if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) { if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) {
sscanf(tmp, "%d ", &mode); sscanf(tmp, "%d ", &mode);
if (pregpriv && mode >= 0 && mode < 2) { if (pregpriv && mode < 2) {
pregpriv->check_fw_ps = mode; pregpriv->check_fw_ps = mode;
DBG_871X("pregpriv->check_fw_ps =%d\n", pregpriv->check_fw_ps); DBG_871X("pregpriv->check_fw_ps =%d\n", pregpriv->check_fw_ps);
} }