mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-28 07:13:34 +00:00
media: uvcvideo: Return -EIO for control errors
The device is doing something unexpected with the control. Either because the protocol is not properly implemented or there has been a HW error. Fixes v4l2-compliance: Control ioctls (Input 0): fail: v4l2-test-controls.cpp(448): s_ctrl returned an error (22) test VIDIOC_G/S_CTRL: FAIL fail: v4l2-test-controls.cpp(698): s_ext_ctrls returned an error (22) test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
parent
97a2777a96
commit
ffccdde5f0
1 changed files with 5 additions and 0 deletions
|
@ -115,6 +115,11 @@ int uvc_query_ctrl(struct uvc_device *dev, u8 query, u8 unit,
|
|||
case 5: /* Invalid unit */
|
||||
case 6: /* Invalid control */
|
||||
case 7: /* Invalid Request */
|
||||
/*
|
||||
* The firmware has not properly implemented
|
||||
* the control or there has been a HW error.
|
||||
*/
|
||||
return -EIO;
|
||||
case 8: /* Invalid value within range */
|
||||
return -EINVAL;
|
||||
default: /* reserved or unknown */
|
||||
|
|
Loading…
Reference in a new issue