mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity
linux-stable/arch/x86/boot
History
Kees Cook 40ea89a471 x86/boot: Wrap literal addresses in absolute_pointer() 
commit aeb8441203 upstream.

GCC 11 (incorrectly[1]) assumes that literal values cast to (void *)
should be treated like a NULL pointer with an offset, and raises
diagnostics when doing bounds checking under -Warray-bounds. GCC 12
got "smarter" about finding these:

  In function 'rdfs8',
      inlined from 'vga_recalc_vertical' at /srv/code/arch/x86/boot/video-mode.c:124:29,
      inlined from 'set_mode' at /srv/code/arch/x86/boot/video-mode.c:163:3:
  /srv/code/arch/x86/boot/boot.h:114:9: warning: array subscript 0 is outside array bounds of 'u8[0]' {aka 'unsigned char[]'} [-Warray-bounds]
    114 |         asm volatile("movb %%fs:%1,%0" : "=q" (v) : "m" (*(u8 *)addr));
        |         ^~~

This has been solved in other places[2] already by using the recently
added absolute_pointer() macro. Do the same here.

  [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99578
  [2] https://lore.kernel.org/all/20210912160149.2227137-1-linux@roeck-us.net/

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20220227195918.705219-1-keescook@chromium.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 		2023-06-09 10:22:53 +02:00
..
compressed x86: link vdso and boot with -z noexecstack --no-warn-rwx-segments 2022-08-25 11:11:10 +02:00
tools x86: boot: Fix EFI stub alignment 2018-11-13 11:14:54 -08:00
.gitignore
…
Makefile x86: link vdso and boot with -z noexecstack --no-warn-rwx-segments 2022-08-25 11:11:10 +02:00
a20.c
…
apm.c
…
bioscall.S x86/boot: Avoid using Intel mnemonics in AT&T syntax asm 2023-01-18 09:26:43 +01:00
bitops.h
…
boot.h x86/boot: Wrap literal addresses in absolute_pointer() 2023-06-09 10:22:53 +02:00
cmdline.c
…
code16gcc.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
copy.S
…
cpu.c
…
cpucheck.c
…
cpuflags.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
cpuflags.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ctype.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
early_serial_console.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
edd.c
…
header.S License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
install.sh
…
main.c x86/boot: Wrap literal addresses in absolute_pointer() 2023-06-09 10:22:53 +02:00
memory.c
…
mkcpustr.c
…
mtools.conf.in
…
pm.c
…
pmjump.S
…
printf.c
…
regs.c
…
setup.ld
…
string.c
…
string.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
tty.c
…
version.c
…
vesa.h
…
video-bios.c
…
video-mode.c
…
video-vesa.c
…
video-vga.c
…
video.c
…
video.h
…