linux-stable/drivers/s390
Jan Höppner ebdc569a07 s390/dasd: protect device queue against concurrent access
commit db46cd1e04 upstream.

In dasd_profile_start() the amount of requests on the device queue are
counted. The access to the device queue is unprotected against
concurrent access. With a lot of parallel I/O, especially with alias
devices enabled, the device queue can change while dasd_profile_start()
is accessing the queue. In the worst case this leads to a kernel panic
due to incorrect pointer accesses.

Fix this by taking the device lock before accessing the queue and
counting the requests. Additionally the check for a valid profile data
pointer can be done earlier to avoid unnecessary locking in a hot path.

Cc:  <stable@vger.kernel.org>
Fixes: 4fa52aa7a8 ("[S390] dasd: add enhanced DASD statistics interface")
Reviewed-by: Stefan Haberland <sth@linux.ibm.com>
Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
Link: https://lore.kernel.org/r/20231025132437.1223363-3-sth@linux.ibm.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-12-08 08:41:59 +01:00
..
block s390/dasd: protect device queue against concurrent access 2023-12-08 08:41:59 +01:00
char s390/zcore: fix race when reading from hardware system area 2022-08-25 11:11:25 +02:00
cio s390/cio: unregister device when the only path is gone 2023-06-28 10:14:21 +02:00
crypto s390/zcrypt: handle new reply code FILTERED_BY_HYPERVISOR 2020-01-04 13:59:54 +01:00
net s390/lcs: Fix return type of lcs_start_xmit() 2023-01-18 09:26:31 +01:00
scsi scsi: zfcp: Fix a double put in zfcp_port_enqueue() 2023-10-10 21:43:40 +02:00
virtio virtio/s390: implement virtio-ccw revision 2 correctly 2021-03-07 11:27:42 +01:00
Makefile