mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity
linux-stable/net/batman-adv
History
Remi Pommarel d63467012c batman-adv: Fix batadv_v_ogm_aggr_send memory leak 
commit 421d467dc2 upstream.

When batadv_v_ogm_aggr_send is called for an inactive interface, the skb
is silently dropped by batadv_v_ogm_send_to_if() but never freed causing
the following memory leak:

  unreferenced object 0xffff00000c164800 (size 512):
    comm "kworker/u8:1", pid 2648, jiffies 4295122303 (age 97.656s)
    hex dump (first 32 bytes):
      00 80 af 09 00 00 ff ff e1 09 00 00 75 01 60 83  ............u.`.
      1f 00 00 00 b8 00 00 00 15 00 05 00 da e3 d3 64  ...............d
    backtrace:
      [<0000000007ad20f6>] __kmalloc_track_caller+0x1a8/0x310
      [<00000000d1029e55>] kmalloc_reserve.constprop.0+0x70/0x13c
      [<000000008b9d4183>] __alloc_skb+0xec/0x1fc
      [<00000000c7af5051>] __netdev_alloc_skb+0x48/0x23c
      [<00000000642ee5f5>] batadv_v_ogm_aggr_send+0x50/0x36c
      [<0000000088660bd7>] batadv_v_ogm_aggr_work+0x24/0x40
      [<0000000042fc2606>] process_one_work+0x3b0/0x610
      [<000000002f2a0b1c>] worker_thread+0xa0/0x690
      [<0000000059fae5d4>] kthread+0x1fc/0x210
      [<000000000c587d3a>] ret_from_fork+0x10/0x20

Free the skb in that case to fix this leak.

Cc: stable@vger.kernel.org
Fixes: 0da0035942 ("batman-adv: OGMv2 - add basic infrastructure")
Signed-off-by: Remi Pommarel <repk@triplefau.lt>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 		2023-08-30 16:35:15 +02:00
..
Kconfig
…
Makefile
…
bat_algo.c
…
bat_algo.h
…
bat_iv_ogm.c batman-adv: Avoid WARN_ON timing related checks 2021-06-30 08:48:48 -04:00
bat_iv_ogm.h
…
bat_v.c batman-adv: Fix check of retrieved orig_gw in batadv_v_gw_is_eligible 2020-03-20 10:54:21 +01:00
bat_v.h
…
bat_v_elp.c batman-adv: Do not get eth header before batadv_check_management_packet 2023-08-30 16:35:15 +02:00
bat_v_elp.h
…
bat_v_ogm.c batman-adv: Fix batadv_v_ogm_aggr_send memory leak 2023-08-30 16:35:15 +02:00
bat_v_ogm.h
…
bitarray.c
…
bitarray.h
…
bridge_loop_avoidance.c batman-adv: mcast: fix duplicate mcast packets from BLA backbone to mesh 2021-11-26 11:40:41 +01:00
bridge_loop_avoidance.h batman-adv: mcast: fix duplicate mcast packets in BLA backbone from mesh 2020-10-01 13:12:51 +02:00
debugfs.c batman-adv: Fix debugfs path for renamed softif 2020-03-20 10:54:22 +01:00
debugfs.h batman-adv: Fix debugfs path for renamed softif 2020-03-20 10:54:22 +01:00
distributed-arp-table.c batman-adv: Broken sync while rescheduling delayed work 2023-06-14 10:35:25 +02:00
distributed-arp-table.h
…
fragmentation.c batman-adv: Don't skb_split skbuffs with frag_list 2022-05-18 09:18:05 +02:00
fragmentation.h
…
gateway_client.c batman-adv: Avoid uninitialized chaddr when handling DHCP 2020-09-09 19:03:07 +02:00
gateway_client.h
…
gateway_common.c
…
gateway_common.h
…
hard-interface.c batman-adv: Trigger events for auto adjusted MTU 2023-08-30 16:35:15 +02:00
hard-interface.h
…
hash.c
…
hash.h
…
icmp_socket.c
…
icmp_socket.h
…
log.c batman-adv: set .owner to THIS_MODULE 2020-12-02 08:34:42 +01:00
log.h
…
main.c net: batman-adv: fix error handling 2021-11-02 18:25:12 +01:00
main.h
…
multicast.c batman-adv: mcast: fix duplicate mcast packets in BLA backbone from LAN 2021-11-26 11:40:41 +01:00
multicast.h batman-adv: mcast: fix duplicate mcast packets in BLA backbone from LAN 2021-11-26 11:40:41 +01:00
netlink.c batman-adv: fix uninit-value in batadv_netlink_get_ifindex() 2019-09-16 08:20:45 +02:00
netlink.h
…
network-coding.c net: batman-adv: fix error handling 2021-11-02 18:25:12 +01:00
network-coding.h
…
originator.c batman-adv: Fix internal interface indices types 2020-03-20 10:54:21 +01:00
originator.h batman-adv: Fix internal interface indices types 2020-03-20 10:54:21 +01:00
packet.h
…
routing.c batman-adv: mcast/TT: fix wrongly dropped or rerouted packets 2020-10-01 13:12:50 +02:00
routing.h
…
send.c batman-adv: fix various spelling mistakes 2017-07-29 09:51:28 +02:00
send.h
…
soft-interface.c batman-adv: mcast: fix duplicate mcast packets in BLA backbone from LAN 2021-11-26 11:40:41 +01:00
soft-interface.h
…
sysfs.c batman-adv: Fix refcnt leak in batadv_store_throughput_override 2020-05-20 08:16:59 +02:00
sysfs.h
…
tp_meter.c
…
tp_meter.h
…
translation-table.c batman-adv: Fix TT global entry leak when client roamed back 2023-08-30 16:35:15 +02:00
translation-table.h
…
tvlv.c batman-adv: Prevent duplicated tvlv handler 2018-10-20 09:48:49 +02:00
tvlv.h
…
types.h batman-adv: Avoid free/alloc race when handling OGM buffer 2020-03-20 10:54:22 +01:00