linux-stable/scripts/kconfig
Masahiro Yamada 07d7941f25 kconfig: display recursive dependency resolution hint just once
commit e3b03bf29d upstream.

Commit 1c199f2878 ("kbuild: document recursive dependency limitation
/ resolution") probably intended to show a hint along with "recursive
dependency detected!" error, but it missed to add {...} guard, and the
hint is displayed in every loop of the dep_stack traverse, annoyingly.

This error was detected by GCC's -Wmisleading-indentation when switching
to build-time generation of lexer/parser.

scripts/kconfig/symbol.c: In function ‘sym_check_print_recursive’:
scripts/kconfig/symbol.c:1150:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
   if (stack->sym == last_sym)
   ^~
scripts/kconfig/symbol.c:1153:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
    fprintf(stderr, "For a resolution refer to Documentation/kbuild/kconfig-language.txt\n");
    ^~~~~~~

I could simply add {...} to surround the three fprintf(), but I rather
chose to move the hint after the loop to make the whole message readable.

Fixes: 1c199f2878 ("kbuild: document recursive dependency limitation / resolution"
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>
Cc: Daniel Díaz <daniel.diaz@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-12-08 11:16:30 +01:00
..
lxdialog kconfig/[mn]conf: handle backspace (^H) key 2019-05-04 09:15:22 +02:00
.gitignore Remove gperf usage from toolchain 2017-08-19 11:02:53 -07:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
POTFILES.in
check.sh License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
conf.c
confdata.c kconfig: fix broken dependency in randconfig-generated .config 2020-02-28 16:35:59 +01:00
expr.c kconfig: don't crash on NULL expressions in expr_eq() 2020-01-12 12:11:58 +01:00
expr.h
gconf.c
gconf.glade
images.c
kconf_id.c Remove gperf usage from toolchain 2017-08-19 11:02:53 -07:00
kxgettext.c
list.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
lkc.h Remove gperf usage from toolchain 2017-08-19 11:02:53 -07:00
lkc_proto.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
mconf.c
menu.c kconfig: Fix automatic menu creation mem leak 2018-04-26 11:02:08 +02:00
merge_config.sh
nconf.c kconfig: nconf: stop endless search loops 2021-05-22 10:57:37 +02:00
nconf.gui.c kconfig/[mn]conf: handle backspace (^H) key 2019-05-04 09:15:22 +02:00
nconf.h
qconf.cc
qconf.h
streamline_config.pl
symbol.c kconfig: display recursive dependency resolution hint just once 2022-12-08 11:16:30 +01:00
util.c
zconf.l kconfig: fix memory leak when EOF is encountered in quotation 2019-01-26 09:37:04 +01:00
zconf.lex.c_shipped
zconf.tab.c_shipped Remove gperf usage from toolchain 2017-08-19 11:02:53 -07:00
zconf.y kconfig: fix the rule of mainmenu_stmt symbol 2018-11-04 14:52:45 +01:00