Michael Kelley 1463575044 nvme: Fix IOC_PR_CLEAR and IOC_PR_RELEASE ioctls for nvme devices ... [ Upstream commit c292a337d0 ] The IOC_PR_CLEAR and IOC_PR_RELEASE ioctls are non-functional on NVMe devices because the nvme_pr_clear() and nvme_pr_release() functions set the IEKEY field incorrectly. The IEKEY field should be set only when the key is zero (i.e, not specified). The current code does it backwards. Furthermore, the NVMe spec describes the persistent reservation "clear" function as an option on the reservation release command. The current implementation of nvme_pr_clear() erroneously uses the reservation register command. Fix these errors. Note that NVMe version 1.3 and later specify that setting the IEKEY field will return an error of Invalid Field in Command. The fix will set IEKEY when the key is zero, which is appropriate as these ioctls consider a zero key to be "unspecified", and the intention of the spec change is to require a valid key. Tested on a version 1.4 PCI NVMe device in an Azure VM. Fixes: 1673f1f08c ("nvme: move block_device_operations and ns/ctrl freeing to common code") Fixes: 1d277a637a ("NVMe: Add persistent reservation ops") Signed-off-by: Michael Kelley <mikelley@microsoft.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-10-26 13:15:33 +02:00
..
host	nvme: Fix IOC_PR_CLEAR and IOC_PR_RELEASE ioctls for nvme devices	2022-10-26 13:15:33 +02:00
target	nvmet: don't check iosqes,iocqes for discovery controllers	2021-03-24 10:59:23 +01:00
Kconfig	nvmet: add a generic NVMe target	2016-07-05 11:30:33 -06:00
Makefile	nvmet: add a generic NVMe target	2016-07-05 11:30:33 -06:00