Vladimir Oltean 19f132730d net: dcb: disable softirqs in dcbnl_flush_dev() ... commit 10b6bb62ae upstream. Ido Schimmel points out that since commit 52cff74eef ("dcbnl : Disable software interrupts before taking dcb_lock"), the DCB API can be called by drivers from softirq context. One such in-tree example is the chelsio cxgb4 driver: dcb_rpl -> cxgb4_dcb_handle_fw_update -> dcb_ieee_setapp If the firmware for this driver happened to send an event which resulted in a call to dcb_ieee_setapp() at the exact same time as another DCB-enabled interface was unregistering on the same CPU, the softirq would deadlock, because the interrupted process was already holding the dcb_lock in dcbnl_flush_dev(). Fix this unlikely event by using spin_lock_bh() in dcbnl_flush_dev() as in the rest of the dcbnl code. Fixes: 91b0383fef ("net: dcb: flush lingering app table entries for unregistered devices") Reported-by: Ido Schimmel <idosch@idosch.org> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Link: https://lore.kernel.org/r/20220302193939.1368823-1-vladimir.oltean@nxp.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-03-08 19:00:59 +01:00
..
Kconfig	…
Makefile	net_dcb: add application notifiers	2010-12-31 10:47:46 -08:00
dcbevent.c	net/*: Fix FSF address in file headers	2013-12-06 12:37:57 -05:00
dcbnl.c	net: dcb: disable softirqs in dcbnl_flush_dev()	2022-03-08 19:00:59 +01:00