mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity
linux-stable/fs/nfs
History
Kuniyuki Iwashima d4891d8173 nfs: Handle error of rpc_proc_register() in nfs_net_init(). 
[ Upstream commit 24457f1be2 ]

syzkaller reported a warning [0] triggered while destroying immature
netns.

rpc_proc_register() was called in init_nfs_fs(), but its error
has been ignored since at least the initial commit 1da177e4c3
("Linux-2.6.12-rc2").

Recently, commit d47151b79e ("nfs: expose /proc/net/sunrpc/nfs
in net namespaces") converted the procfs to per-netns and made
the problem more visible.

Even when rpc_proc_register() fails, nfs_net_init() could succeed,
and thus nfs_net_exit() will be called while destroying the netns.

Then, remove_proc_entry() will be called for non-existing proc
directory and trigger the warning below.

Let's handle the error of rpc_proc_register() properly in nfs_net_init().

[0]:
name 'nfs'
WARNING: CPU: 1 PID: 1710 at fs/proc/generic.c:711 remove_proc_entry+0x1bb/0x2d0 fs/proc/generic.c:711
Modules linked in:
CPU: 1 PID: 1710 Comm: syz-executor.2 Not tainted 6.8.0-12822-gcd51db110a7e #12
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014
RIP: 0010:remove_proc_entry+0x1bb/0x2d0 fs/proc/generic.c:711
Code: 41 5d 41 5e c3 e8 85 09 b5 ff 48 c7 c7 88 58 64 86 e8 09 0e 71 02 e8 74 09 b5 ff 4c 89 e6 48 c7 c7 de 1b 80 84 e8 c5 ad 97 ff <0f> 0b eb b1 e8 5c 09 b5 ff 48 c7 c7 88 58 64 86 e8 e0 0d 71 02 eb
RSP: 0018:ffffc9000c6d7ce0 EFLAGS: 00010286
RAX: 0000000000000000 RBX: ffff8880422b8b00 RCX: ffffffff8110503c
RDX: ffff888030652f00 RSI: ffffffff81105045 RDI: 0000000000000001
RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000001 R11: ffffffff81bb62cb R12: ffffffff84807ffc
R13: ffff88804ad6fcc0 R14: ffffffff84807ffc R15: ffffffff85741ff8
FS:  00007f30cfba8640(0000) GS:ffff88807dd00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007ff51afe8000 CR3: 000000005a60a005 CR4: 0000000000770ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
PKRU: 55555554
Call Trace:
 <TASK>
 rpc_proc_unregister+0x64/0x70 net/sunrpc/stats.c:310
 nfs_net_exit+0x1c/0x30 fs/nfs/inode.c:2438
 ops_exit_list+0x62/0xb0 net/core/net_namespace.c:170
 setup_net+0x46c/0x660 net/core/net_namespace.c:372
 copy_net_ns+0x244/0x590 net/core/net_namespace.c:505
 create_new_namespaces+0x2ed/0x770 kernel/nsproxy.c:110
 unshare_nsproxy_namespaces+0xae/0x160 kernel/nsproxy.c:228
 ksys_unshare+0x342/0x760 kernel/fork.c:3322
 __do_sys_unshare kernel/fork.c:3393 [inline]
 __se_sys_unshare kernel/fork.c:3391 [inline]
 __x64_sys_unshare+0x1f/0x30 kernel/fork.c:3391
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0x4f/0x110 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x46/0x4e
RIP: 0033:0x7f30d0febe5d
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 73 9f 1b 00 f7 d8 64 89 01 48
RSP: 002b:00007f30cfba7cc8 EFLAGS: 00000246 ORIG_RAX: 0000000000000110
RAX: ffffffffffffffda RBX: 00000000004bbf80 RCX: 00007f30d0febe5d
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 000000006c020600
RBP: 00000000004bbf80 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000002
R13: 000000000000000b R14: 00007f30d104c530 R15: 0000000000000000
 </TASK>

Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Reported-by: syzkaller <syzkaller@googlegroups.com>
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
 		2024-05-17 11:47:59 +02:00
..
blocklayout blocklayoutdriver: Fix reference leak of pnfs_device_node 2024-01-25 14:37:43 -08:00
filelayout pNFS/filelayout: Fix coalescing test for single DS 2023-01-24 07:19:55 +01:00
flexfilelayout NFS/pNFS: Report EINVAL errors from connect() to the server 2023-10-10 21:53:24 +02:00
Kconfig
…
Makefile
…
cache_lib.c
…
cache_lib.h
…
callback.c
…
callback.h NFSv4.1: Fix uninitialised variable in devicenotify 2022-02-16 12:54:18 +01:00
callback_proc.c pNFS: Avoid a live lock condition in pnfs_update_layout() 2022-06-22 14:13:16 +02:00
callback_xdr.c NFS: remove unneeded check in decode_devicenotify_args() 2022-04-08 14:40:27 +02:00
client.c nfs: make the rpc_stat per net namespace 2024-05-17 11:47:59 +02:00
delegation.c NFSv4: Fix a potential state reclaim deadlock 2022-11-10 18:14:16 +01:00
delegation.h
…
dir.c NFSv4: fix open failure with O_ACCMODE flag 2022-04-13 21:01:04 +02:00
direct.c nfs: fix UAF in direct writes 2024-04-13 12:58:31 +02:00
dns_resolve.c
…
dns_resolve.h
…
export.c
…
file.c NFSv4: keep state manager thread active if swap is enabled 2023-03-11 16:39:38 +01:00
fs_context.c nfs: fix broken handling of the softreval mount option 2022-05-18 10:23:43 +02:00
fscache-index.c
…
fscache.c
…
fscache.h
…
getroot.c
…
inode.c nfs: Handle error of rpc_proc_register() in nfs_net_init(). 2024-05-17 11:47:59 +02:00
internal.h nfs: make the rpc_stat per net namespace 2024-05-17 11:47:59 +02:00
io.c
…
iostat.h
…
mount_clnt.c
…
namespace.c NFS: Fix an Oops in nfs_d_automount() 2023-01-14 10:15:34 +01:00
netns.h nfs: make the rpc_stat per net namespace 2024-05-17 11:47:59 +02:00
nfs.h
…
nfs2super.c
…
nfs2xdr.c NFS: Guard against READDIR loop when entry names exceed MAXNAMELEN 2023-09-19 12:20:15 +02:00
nfs3_fs.h
…
nfs3acl.c
…
nfs3client.c Revert "pNFS: nfs3_set_ds_client should set NFS_CS_NOPING" 2022-08-21 15:15:18 +02:00
nfs3proc.c
…
nfs3super.c
…
nfs3xdr.c NFS: Guard against READDIR loop when entry names exceed MAXNAMELEN 2023-09-19 12:20:15 +02:00
nfs4_fs.h NFSv4: keep state manager thread active if swap is enabled 2023-03-11 16:39:38 +01:00
nfs4client.c nfs4: Fix kmemleak when allocate slot failed 2022-11-10 18:14:16 +01:00
nfs4file.c NFSv4.2 fix problems with __nfs42_ssc_open 2022-08-31 17:15:15 +02:00
nfs4getroot.c
…
nfs4idmap.c NFSv4: Fix races in the legacy idmapper upcall 2022-08-25 11:37:54 +02:00
nfs4idmap.h
…
nfs4namespace.c NFSv4 handle port presence in fs_location server string 2022-02-16 12:54:18 +01:00
nfs4proc.c NFSv4.2: fix nfs4_listxattr kernel BUG at mm/usercopy.c:102 2024-03-26 18:22:01 -04:00
nfs4renewd.c
…
nfs4session.c
…
nfs4session.h
…
nfs4state.c NFSv4: Fix a nfs4_state_manager() race 2023-10-10 21:53:38 +02:00
nfs4super.c
…
nfs4sysctl.c
…
nfs4trace.c
…
nfs4trace.h nfs4trace: fix state manager flag printing 2023-03-11 16:39:38 +01:00
nfs4xdr.c NFSv4.2: Fix a memory stomp in decode_attr_security_label 2023-01-14 10:15:33 +01:00
nfs42.h NFSv4.2: fix listxattr maximum XDR buffer size 2024-03-26 18:22:01 -04:00
nfs42proc.c NFSv4.2: fix handling of COPY ERR_OFFLOAD_NO_REQ 2023-09-19 12:20:16 +02:00
nfs42xattr.c
…
nfs42xdr.c NFSv42: Don't fail clone() unless the OP_CLONE operation failed 2021-12-01 09:19:03 +01:00
nfsroot.c NFS: Fix an off by one in root_nfs_cat() 2024-03-26 18:22:01 -04:00
nfstrace.c
…
nfstrace.h
…
pagelist.c NFS: Avoid writeback threads getting stuck in mempool_alloc() 2022-04-13 21:01:03 +02:00
pnfs.c pNFS: Fix a hang in nfs4_evict_inode() 2023-10-25 11:54:24 +02:00
pnfs.h pNFS: Avoid a live lock condition in pnfs_update_layout() 2022-06-22 14:13:16 +02:00
pnfs_dev.c NFSv4/pnfs: minor fix for cleanup path in nfs4_get_device_info 2023-09-19 12:20:25 +02:00
pnfs_nfs.c NFS: nfsiod should not block forever in mempool_alloc() 2022-04-13 21:01:03 +02:00
proc.c
…
read.c
…
super.c NFSv4: Turn off open-by-filehandle and NFS re-export for NFSv4.0 2022-09-23 14:16:57 +02:00
symlink.c
…
sysctl.c
…
sysfs.c NFS: rename nfs_client_kset to nfs_kset 2023-10-10 21:53:36 +02:00
sysfs.h
…
unlink.c
…
write.c nfs: fix UAF in direct writes 2024-04-13 12:58:31 +02:00