Eric Dumazet 2295a7ef5c net: fix __dst_negative_advice() race ... commit 92f1655aa2 upstream. __dst_negative_advice() does not enforce proper RCU rules when sk->dst_cache must be cleared, leading to possible UAF. RCU rules are that we must first clear sk->sk_dst_cache, then call dst_release(old_dst). Note that sk_dst_reset(sk) is implementing this protocol correctly, while __dst_negative_advice() uses the wrong order. Given that ip6_negative_advice() has special logic against RTF_CACHE, this means each of the three ->negative_advice() existing methods must perform the sk_dst_reset() themselves. Note the check against NULL dst is centralized in __dst_negative_advice(), there is no need to duplicate it in various callbacks. Many thanks to Clement Lecigne for tracking this issue. This old bug became visible after the blamed commit, using UDP sockets. Fixes: a87cb3e48e ("net: Facility to report route quality of connected sockets") Reported-by: Clement Lecigne <clecigne@google.com> Diagnosed-by: Clement Lecigne <clecigne@google.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Tom Herbert <tom@herbertland.com> Reviewed-by: David Ahern <dsahern@kernel.org> Link: https://lore.kernel.org/r/20240528114353.1794151-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> [Lee: Stable backport] Signed-off-by: Lee Jones <lee@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-06-16 13:32:36 +02:00
..
Kconfig	xfrm/compat: Add 32=>64-bit messages translator	2020-09-24 08:53:03 +02:00
Makefile	xfrm: interface: rename xfrm_interface.c to xfrm_interface_core.c	2023-06-28 10:28:10 +02:00
espintcp.c	net: Fix data-races around netdev_max_backlog.	2022-08-31 17:15:19 +02:00
xfrm_algo.c	…
xfrm_compat.c	net: xfrm: Amend XFRMA_SEC_CTX nla_policy structure	2023-08-26 15:26:51 +02:00
xfrm_device.c	xfrm: replay: Fix ESN wrap around for GSO	2022-12-02 17:39:58 +01:00
xfrm_hash.c	…
xfrm_hash.h	…
xfrm_inout.h	xfrm: move xfrm4_extract_header to common helper	2020-05-06 09:40:08 +02:00
xfrm_input.c	xfrm: Preserve vlan tags for transport mode software GRO	2024-05-17 11:48:06 +02:00
xfrm_interface_core.c	xfrm: interface: use DEV_STATS_INC()	2023-10-25 11:54:19 +02:00
xfrm_ipcomp.c	xfrm: Update ipcomp_scratches with NULL when freed	2022-10-26 13:25:46 +02:00
xfrm_output.c	xfrm: remove the fragment check for ipv6 beet mode	2021-07-14 16:56:19 +02:00
xfrm_policy.c	net: fix __dst_negative_advice() race	2024-06-16 13:32:36 +02:00
xfrm_proc.c	…
xfrm_replay.c	xfrm: replay: Fix ESN wrap around for GSO	2022-12-02 17:39:58 +01:00
xfrm_state.c	xfrm: Allow transport-mode states with AF_UNSPEC selector	2023-03-22 13:29:55 +01:00
xfrm_sysctl.c	…
xfrm_user.c	xfrm: Avoid clang fortify warning in copy_to_user_tmpl()	2024-04-13 12:58:49 +02:00