mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity
linux-stable/fs/cachefiles
History
Baokun Li 94965be37a cachefiles: fix memory leak in cachefiles_add_cache() 
commit e21a2f1756 upstream.

The following memory leak was reported after unbinding /dev/cachefiles:

==================================================================
unreferenced object 0xffff9b674176e3c0 (size 192):
  comm "cachefilesd2", pid 680, jiffies 4294881224
  hex dump (first 32 bytes):
    01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace (crc ea38a44b):
    [<ffffffff8eb8a1a5>] kmem_cache_alloc+0x2d5/0x370
    [<ffffffff8e917f86>] prepare_creds+0x26/0x2e0
    [<ffffffffc002eeef>] cachefiles_determine_cache_security+0x1f/0x120
    [<ffffffffc00243ec>] cachefiles_add_cache+0x13c/0x3a0
    [<ffffffffc0025216>] cachefiles_daemon_write+0x146/0x1c0
    [<ffffffff8ebc4a3b>] vfs_write+0xcb/0x520
    [<ffffffff8ebc5069>] ksys_write+0x69/0xf0
    [<ffffffff8f6d4662>] do_syscall_64+0x72/0x140
    [<ffffffff8f8000aa>] entry_SYSCALL_64_after_hwframe+0x6e/0x76
==================================================================

Put the reference count of cache_cred in cachefiles_daemon_unbind() to
fix the problem. And also put cache_cred in cachefiles_add_cache() error
branch to avoid memory leaks.

Fixes: 9ae326a690 ("CacheFiles: A cache that backs onto a mounted filesystem")
CC: stable@vger.kernel.org
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Link: https://lore.kernel.org/r/20240217081431.796809-1-libaokun1@huawei.com
Acked-by: David Howells <dhowells@redhat.com>
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 		2024-03-06 14:38:50 +00:00
..
Kconfig fscache, cachefiles: Remove the histogram stuff 2021-08-27 13:34:02 +01:00
Makefile fscache, cachefiles: Remove the histogram stuff 2021-08-27 13:34:02 +01:00
bind.c cachefiles: fix memory leak in cachefiles_add_cache() 2024-03-06 14:38:50 +00:00
daemon.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36 2019-05-24 17:27:11 +02:00
interface.c cachefiles: Change %p in format strings to something else 2021-08-27 13:34:02 +01:00
internal.h fscache, cachefiles: Remove the histogram stuff 2021-08-27 13:34:02 +01:00
io.c cachefiles: Use file_inode() rather than accessing ->f_inode 2021-08-25 15:20:25 +01:00
key.c cachefiles: Change %p in format strings to something else 2021-08-27 13:34:02 +01:00
main.c fscache, cachefiles: Remove the histogram stuff 2021-08-27 13:34:02 +01:00
namei.c cachefiles: Change %p in format strings to something else 2021-08-27 13:34:02 +01:00
rdwr.c fs/cachefiles: Remove wait_bit_key layout dependency 2021-03-23 20:54:29 +00:00
security.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36 2019-05-24 17:27:11 +02:00
xattr.c cachefiles: Change %p in format strings to something else 2021-08-27 13:34:02 +01:00