linux-stable/fs/nilfs2
Ryusuke Konishi e65ccf3a4d nilfs2: fix use-after-free of timer for log writer thread
commit f5d4e04634 upstream.

Patch series "nilfs2: fix log writer related issues".

This bug fix series covers three nilfs2 log writer-related issues,
including a timer use-after-free issue and potential deadlock issue on
unmount, and a potential freeze issue in event synchronization found
during their analysis.  Details are described in each commit log.


This patch (of 3):

A use-after-free issue has been reported regarding the timer sc_timer on
the nilfs_sc_info structure.

The problem is that even though it is used to wake up a sleeping log
writer thread, sc_timer is not shut down until the nilfs_sc_info structure
is about to be freed, and is used regardless of the thread's lifetime.

Fix this issue by limiting the use of sc_timer only while the log writer
thread is alive.

Link: https://lkml.kernel.org/r/20240520132621.4054-1-konishi.ryusuke@gmail.com
Link: https://lkml.kernel.org/r/20240520132621.4054-2-konishi.ryusuke@gmail.com
Fixes: fdce895ea5 ("nilfs2: change sc_timer from a pointer to an embedded one in struct nilfs_sc_info")
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Reported-by: "Bai, Shuangpeng" <sjb7183@psu.edu>
Closes: https://groups.google.com/g/syzkaller/c/MK_LYqtt8ko/m/8rgdWeseAwAJ
Tested-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-06-16 13:39:54 +02:00
..
Kconfig
Makefile
alloc.c nilfs2: fix WARNING in mark_buffer_dirty due to discarded buffer reuse 2023-09-06 21:28:40 +01:00
alloc.h
bmap.c nilfs2: fix infinite loop in nilfs_mdt_get_block() 2023-05-11 23:00:39 +09:00
bmap.h
btnode.c nilfs2: fix incomplete buffer cleanup in nilfs_btnode_abort_change_key() 2023-06-21 15:59:14 +02:00
btnode.h nilfs2: fix lockdep warnings in page operations for btree nodes 2022-05-25 09:57:26 +02:00
btree.c nilfs2: fix failure to detect DAT corruption in btree and direct mappings 2024-04-10 16:18:42 +02:00
btree.h
cpfile.c
cpfile.h
dat.c nilfs2: replace WARN_ONs for invalid DAT metadata block requests 2024-02-23 08:55:14 +01:00
dat.h
dir.c nilfs2: fix OOB in nilfs_set_de_type 2024-04-27 17:05:29 +02:00
direct.c nilfs2: fix failure to detect DAT corruption in btree and direct mappings 2024-04-10 16:18:42 +02:00
direct.h
export.h
file.c nilfs2: fix hang in nilfs_lookup_dirty_data_buffers() 2024-02-23 08:55:08 +01:00
gcinode.c nilfs2: fix potential use after free in nilfs_gccache_submit_read_data() 2023-10-06 13:18:21 +02:00
ifile.c
ifile.h
inode.c nilfs2: prevent kernel bug at submit_bh_wbc() 2024-04-10 16:18:43 +02:00
ioctl.c nilfs2: fix out-of-range warning 2024-06-16 13:39:16 +02:00
mdt.c nilfs2: fix lockdep warnings during disk space reclamation 2022-05-25 09:57:26 +02:00
mdt.h nilfs2: fix lockdep warnings during disk space reclamation 2022-05-25 09:57:26 +02:00
namei.c
nilfs.h nilfs2: fix incorrect masking of permission flags for symlinks 2022-07-21 21:24:14 +02:00
page.c nilfs2: prevent general protection fault in nilfs_clear_dirty_page() 2023-06-28 10:29:45 +02:00
page.h
recovery.c nilfs2: fix data corruption in dsync block recovery for small block sizes 2024-02-23 08:55:08 +01:00
segbuf.c nilfs2: fix buffer corruption due to concurrent device reads 2023-06-28 10:29:42 +02:00
segbuf.h
segment.c nilfs2: fix use-after-free of timer for log writer thread 2024-06-16 13:39:54 +02:00
segment.h
sufile.c nilfs2: prevent WARNING in nilfs_sufile_set_segment_usage() 2023-12-13 18:36:43 +01:00
sufile.h
super.c nilfs2: fix buffer corruption due to concurrent device reads 2023-06-28 10:29:42 +02:00
sysfs.c nilfs2: fix memory leak in nilfs_sysfs_delete_snapshot_group 2021-09-08 11:50:27 -07:00
sysfs.h
the_nilfs.c nilfs2: fix missing error check for sb_set_blocksize call 2023-12-13 18:36:42 +01:00
the_nilfs.h nilfs2: fix use-after-free of nilfs_root in dirtying inodes via iput 2023-08-16 18:21:58 +02:00