linux-stable/drivers/firmware/cirrus
Richard Fitzgerald 07ab8ba8c7 firmware: cs_dsp: Fix overrun of unterminated control name string
[ Upstream commit 5b933c7262 ]

For wmfw format v2 and later the coefficient name strings have a length
field and are NOT null-terminated. Use kasprintf() to convert the
unterminated string into a null-terminated string in an allocated buffer.

The previous code handled this duplication incorrectly using kmemdup()
and getting the length from a strlen() of the (unterminated) source string.
This resulted in creating a string that continued up to the next byte in
the firmware file that just happened to be 0x00.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: f6bc909e76 ("firmware: cs_dsp: add driver to support firmware loading on Cirrus Logic DSPs")
Link: https://lore.kernel.org/r/20220412163927.1303470-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-04-27 14:40:57 +02:00
..
cs_dsp.c firmware: cs_dsp: Fix overrun of unterminated control name string 2022-04-27 14:40:57 +02:00
Kconfig
Makefile