Duoming Zhou eca9748d92 drivers: staging: rtl8192bs: Fix deadlock in rtw_joinbss_event_prehandle() ... [ Upstream commit 041879b12d ] There is a deadlock in rtw_joinbss_event_prehandle(), which is shown below: (Thread 1) | (Thread 2) | _set_timer() rtw_joinbss_event_prehandle()| mod_timer() spin_lock_bh() //(1) | (wait a time) ... | _rtw_join_timeout_handler() del_timer_sync() | spin_lock_bh() //(2) (wait timer to stop) | ... We hold pmlmepriv->lock in position (1) of thread 1 and use del_timer_sync() to wait timer to stop, but timer handler also need pmlmepriv->lock in position (2) of thread 2. As a result, rtw_joinbss_event_prehandle() will block forever. This patch extracts del_timer_sync() from the protection of spin_lock_bh(), which could let timer handler to obtain the needed lock. What`s more, we change spin_lock_bh() to spin_lock_irq() in _rtw_join_timeout_handler() in order to prevent deadlock. Signed-off-by: Duoming Zhou <duoming@zju.edu.cn> Link: https://lore.kernel.org/r/20220409064953.67420-1-duoming@zju.edu.cn Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-06-14 18:45:09 +02:00
..
core	drivers: staging: rtl8192bs: Fix deadlock in rtw_joinbss_event_prehandle()	2022-06-14 18:45:09 +02:00
hal	Merge 5.17-rc8 into staging-next	2022-03-14 15:06:38 +01:00
include	Staging driver update for 5.18-rc1	2022-03-28 12:50:50 -07:00
os_dep	Staging: rtl8723bs: Placing opening { braces in previous line	2022-01-25 16:25:43 +01:00
Kconfig	staging: rtl8723bs: fix unmet dependency on CRYPTO for CRYPTO_LIB_ARC4	2021-10-30 11:12:50 +02:00
Makefile	staging: rtl8723bs: remove empty files	2021-08-10 12:12:19 +02:00
TODO	staging: rtl8723bs: remove item from TODO list	2021-06-24 14:43:46 +02:00