linux-stable/net/phonet
Oliver Hartkopp f77cde4a26 net: remove noblock parameter from skb_recv_datagram()
[ Upstream commit f4b41f062c ]

skb_recv_datagram() has two parameters 'flags' and 'noblock' that are
merged inside skb_recv_datagram() by 'flags | (noblock ? MSG_DONTWAIT : 0)'

As 'flags' may contain MSG_DONTWAIT as value most callers split the 'flags'
into 'flags' and 'noblock' with finally obsolete bit operations like this:

skb_recv_datagram(sk, flags & ~MSG_DONTWAIT, flags & MSG_DONTWAIT, &rc);

And this is not even done consistently with the 'flags' parameter.

This patch removes the obsolete and costly splitting into two parameters
and only performs bit operations when really needed on the caller side.

One missing conversion thankfully reported by kernel test robot. I missed
to enable kunit tests to build the mctp code.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-06-22 14:28:02 +02:00
..
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile
af_phonet.c phonet: Use netif_rx(). 2022-03-07 11:40:41 +00:00
datagram.c net: remove noblock parameter from skb_recv_datagram() 2022-06-22 14:28:02 +02:00
pep-gprs.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336 2019-06-05 17:37:07 +02:00
pep.c net: remove noblock parameter from skb_recv_datagram() 2022-06-22 14:28:02 +02:00
pn_dev.c net: Remove redundant if statements 2021-08-05 13:27:50 +01:00
pn_netlink.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336 2019-06-05 17:37:07 +02:00
socket.c net: Remove redundant if statements 2021-08-05 13:27:50 +01:00
sysctl.c sysctl: pass kernel pointers to ->proc_handler 2020-04-27 02:07:40 -04:00